Paper/patches/server/0336-Don-t-run-entity-collision-code-if-not-needed.patch

44 lines
2.4 KiB
Diff
Raw Normal View History

2022-12-07 21:16:54 +01:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Spottedleaf <Spottedleaf@users.noreply.github.com>
Date: Wed, 15 Apr 2020 17:56:07 -0700
Subject: [PATCH] Don't run entity collision code if not needed
Will not run if:
Max entity cramming is disabled and the max collisions per entity is less than or equal to 0.
Entity#isPushable() returns false, meaning all entities will not be able to collide with this
entity anyways.
The entity's current team collision rule causes them to NEVER collide.
Co-authored-by: Owen1212055 <23108066+Owen1212055@users.noreply.github.com>
diff --git a/src/main/java/net/minecraft/world/entity/LivingEntity.java b/src/main/java/net/minecraft/world/entity/LivingEntity.java
index a874913997c80c8f47f395e2ef4bb959aaa3e76d..b01e472a8a5f05e586bfa35e33abfd3875518ab3 100644
2022-12-07 21:16:54 +01:00
--- a/src/main/java/net/minecraft/world/entity/LivingEntity.java
+++ b/src/main/java/net/minecraft/world/entity/LivingEntity.java
@@ -3682,10 +3682,24 @@ public abstract class LivingEntity extends Entity implements Attackable {
2024-10-23 16:04:01 +02:00
if (!(world instanceof ServerLevel worldserver)) {
2023-06-08 00:41:25 +02:00
this.level().getEntities(EntityTypeTest.forClass(net.minecraft.world.entity.player.Player.class), this.getBoundingBox(), EntitySelector.pushableBy(this)).forEach(this::doPush);
2022-12-07 21:16:54 +01:00
} else {
+ // Paper start - don't run getEntities if we're not going to use its result
+ if (!this.isPushable()) {
+ return;
+ }
+ net.minecraft.world.scores.Team team = this.getTeam();
+ if (team != null && team.getCollisionRule() == net.minecraft.world.scores.Team.CollisionRule.NEVER) {
+ return;
+ }
+
2024-10-25 12:30:19 +02:00
+ int i = worldserver.getGameRules().getInt(GameRules.RULE_MAX_ENTITY_CRAMMING);
2023-06-08 00:41:25 +02:00
+ if (i <= 0 && this.level().paperConfig().collisions.maxEntityCollisions <= 0) {
2022-12-07 21:16:54 +01:00
+ return;
+ }
+ // Paper end - don't run getEntities if we're not going to use its result
2024-10-23 16:04:01 +02:00
List list = this.level().getEntities((Entity) this, this.getBoundingBox(), EntitySelector.pushableBy(this));
2022-12-07 21:16:54 +01:00
if (!list.isEmpty()) {
2024-10-23 16:04:01 +02:00
- int i = worldserver.getGameRules().getInt(GameRules.RULE_MAX_ENTITY_CRAMMING);
+ // Paper - don't run getEntities if we're not going to use its result; moved up
2022-12-07 21:16:54 +01:00
if (i > 0 && list.size() > i - 1 && this.random.nextInt(4) == 0) {
2023-09-22 05:29:51 +02:00
int j = 0;