2023-08-21 06:50:11 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: EpicPlayerA10 <adasko.lesiak@gmail.com>
|
|
|
|
Date: Sun, 18 Jun 2023 12:38:24 +0200
|
|
|
|
Subject: [PATCH] Don't tab-complete namespaced commands if send-namespaced is
|
|
|
|
false
|
|
|
|
|
|
|
|
Tab-complete packet is supposed to tab-complete args for commands, but
|
|
|
|
it also can suggest commands like in version 1.12.2 or lower.
|
|
|
|
|
|
|
|
This patch prevents server from sending namespaced commands when player
|
|
|
|
requests tab-complete only commands.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
2024-04-25 23:21:18 +02:00
|
|
|
index 699d8d4b2333da1b3e83e39167de44ab69ab9029..6d5cf94979fba9d27f91b51682a3b7b3f67c07ea 100644
|
2023-08-21 06:50:11 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/network/ServerGamePacketListenerImpl.java
|
2024-04-25 23:21:18 +02:00
|
|
|
@@ -817,6 +817,11 @@ public class ServerGamePacketListenerImpl extends ServerCommonPacketListenerImpl
|
2024-02-05 12:31:51 +01:00
|
|
|
ParseResults<CommandSourceStack> parseresults = this.server.getCommands().getDispatcher().parse(stringreader, this.player.createCommandSourceStack());
|
2023-08-21 06:50:11 +02:00
|
|
|
|
2024-02-05 12:31:51 +01:00
|
|
|
this.server.getCommands().getDispatcher().getCompletionSuggestions(parseresults).thenAccept((suggestions) -> {
|
|
|
|
+ // Paper start - Don't tab-complete namespaced commands if send-namespaced is false
|
|
|
|
+ if (!org.spigotmc.SpigotConfig.sendNamespaced && suggestions.getRange().getStart() <= 1) {
|
|
|
|
+ suggestions.getList().removeIf(suggestion -> suggestion.getText().contains(":"));
|
|
|
|
+ }
|
|
|
|
+ // Paper end - Don't tab-complete namespaced commands if send-namespaced is false
|
|
|
|
// Paper start - Brigadier API
|
|
|
|
com.destroystokyo.paper.event.brigadier.AsyncPlayerSendSuggestionsEvent suggestEvent = new com.destroystokyo.paper.event.brigadier.AsyncPlayerSendSuggestionsEvent(this.getCraftPlayer(), suggestions, packet.getCommand());
|
|
|
|
suggestEvent.setCancelled(suggestions.isEmpty());
|