Paper/patches/server/0673-Fix-NotePlayEvent.patch

55 lines
3.6 KiB
Diff
Raw Normal View History

2022-12-07 22:35:34 +01:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Kieran Wallbanks <kieran.wallbanks@gmail.com>
Date: Mon, 21 Jun 2021 14:23:50 +0100
Subject: [PATCH] Fix NotePlayEvent
== AT ==
public org.bukkit.craftbukkit.block.data.CraftBlockData toNMS(Ljava/lang/Enum;Ljava/lang/Class;)Ljava/lang/Enum;
diff --git a/src/main/java/net/minecraft/world/level/block/NoteBlock.java b/src/main/java/net/minecraft/world/level/block/NoteBlock.java
2024-04-24 19:59:51 +02:00
index 6215f096849f48843d6e25875b8b71f6827ec0a5..f77d51d10e01fc4eaf5516c05c8be0ef7a425893 100644
2022-12-07 22:35:34 +01:00
--- a/src/main/java/net/minecraft/world/level/block/NoteBlock.java
+++ b/src/main/java/net/minecraft/world/level/block/NoteBlock.java
2024-04-24 19:59:51 +02:00
@@ -94,11 +94,12 @@ public class NoteBlock extends Block {
2022-12-07 22:35:34 +01:00
private void playNote(@Nullable Entity entity, BlockState state, Level world, BlockPos pos) {
2023-06-08 10:08:08 +02:00
if (((NoteBlockInstrument) state.getValue(NoteBlock.INSTRUMENT)).worksAboveNoteBlock() || world.getBlockState(pos.above()).isAir()) {
2022-12-07 22:35:34 +01:00
// CraftBukkit start
- org.bukkit.event.block.NotePlayEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callNotePlayEvent(world, pos, state.getValue(NoteBlock.INSTRUMENT), state.getValue(NoteBlock.NOTE));
- if (event.isCancelled()) {
- return;
- }
+ // org.bukkit.event.block.NotePlayEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callNotePlayEvent(world, pos, state.getValue(NoteBlock.INSTRUMENT), state.getValue(NoteBlock.NOTE));
+ // if (event.isCancelled()) {
+ // return;
+ // }
// CraftBukkit end
+ // Paper - move NotePlayEvent call to fix instrument/note changes; TODO any way to cancel the game event?
2022-12-07 22:35:34 +01:00
world.blockEvent(pos, this, 0, 0);
2024-04-24 19:59:51 +02:00
world.gameEvent(entity, (Holder) GameEvent.NOTE_BLOCK_PLAY, pos);
2022-12-07 22:35:34 +01:00
}
2024-04-24 19:59:51 +02:00
@@ -138,10 +139,14 @@ public class NoteBlock extends Block {
2022-12-07 22:35:34 +01:00
@Override
2024-04-24 19:59:51 +02:00
protected boolean triggerEvent(BlockState state, Level world, BlockPos pos, int type, int data) {
NoteBlockInstrument blockpropertyinstrument = (NoteBlockInstrument) state.getValue(NoteBlock.INSTRUMENT);
2022-12-07 22:35:34 +01:00
+ // Paper start - move NotePlayEvent call to fix instrument/note changes
+ org.bukkit.event.block.NotePlayEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callNotePlayEvent(world, pos, blockpropertyinstrument, state.getValue(NOTE));
2022-12-07 22:35:34 +01:00
+ if (event.isCancelled()) return false;
+ // Paper end - move NotePlayEvent call to fix instrument/note changes
2022-12-07 22:35:34 +01:00
float f;
if (blockpropertyinstrument.isTunable()) {
- int k = (Integer) state.getValue(NoteBlock.NOTE);
+ int k = event.getNote().getId(); // Paper - move NotePlayEvent call to fix instrument/note changes
2022-12-07 22:35:34 +01:00
2023-06-08 10:08:08 +02:00
f = NoteBlock.getPitchFromNote(k);
2022-12-07 22:35:34 +01:00
world.addParticle(ParticleTypes.NOTE, (double) pos.getX() + 0.5D, (double) pos.getY() + 1.2D, (double) pos.getZ() + 0.5D, (double) k / 24.0D, 0.0D, 0.0D);
2024-04-24 19:59:51 +02:00
@@ -160,7 +165,7 @@ public class NoteBlock extends Block {
2022-12-07 22:35:34 +01:00
holder = Holder.direct(SoundEvent.createVariableRangeEvent(minecraftkey));
} else {
- holder = blockpropertyinstrument.getSoundEvent();
+ holder = org.bukkit.craftbukkit.block.data.CraftBlockData.toNMS(event.getInstrument(), NoteBlockInstrument.class).getSoundEvent(); // Paper - move NotePlayEvent call to fix instrument/note changes
}
2022-12-07 22:35:34 +01:00
world.playSeededSound((Player) null, (double) pos.getX() + 0.5D, (double) pos.getY() + 0.5D, (double) pos.getZ() + 0.5D, holder, SoundSource.RECORDS, 3.0F, f, world.random.nextLong());