2023-09-16 23:18:09 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Aeltumn <daniel@goossens.ch>
|
|
|
|
Date: Mon, 28 Aug 2023 13:44:09 +0200
|
|
|
|
Subject: [PATCH] Allow proper checking of empty item stacks
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
2024-04-12 23:16:22 +02:00
|
|
|
index f106db3aa5e5b3b0b8133eff77dbc65c8895ff2e..38ceeca108c258852eeb7a48015010a689ac43ec 100644
|
2023-09-16 23:18:09 +02:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftItemStack.java
|
2024-04-12 23:16:22 +02:00
|
|
|
@@ -37,12 +37,19 @@ public final class CraftItemStack extends ItemStack {
|
2023-09-16 23:18:09 +02:00
|
|
|
}
|
|
|
|
// Paper end - MC Utils
|
|
|
|
|
|
|
|
+ // Paper start - override isEmpty to use vanilla's impl
|
|
|
|
+ @Override
|
|
|
|
+ public boolean isEmpty() {
|
|
|
|
+ return handle == null || handle.isEmpty();
|
|
|
|
+ }
|
2024-01-13 18:34:33 +01:00
|
|
|
+ // Paper end - override isEmpty to use vanilla's impl
|
2023-09-16 23:18:09 +02:00
|
|
|
+
|
|
|
|
public static net.minecraft.world.item.ItemStack asNMSCopy(ItemStack original) {
|
|
|
|
if (original instanceof CraftItemStack) {
|
|
|
|
CraftItemStack stack = (CraftItemStack) original;
|
|
|
|
return stack.handle == null ? net.minecraft.world.item.ItemStack.EMPTY : stack.handle.copy();
|
|
|
|
}
|
|
|
|
- if (original == null || original.getType() == Material.AIR) {
|
2024-01-13 18:34:33 +01:00
|
|
|
+ if (original == null || original.isEmpty()) { // Paper - override isEmpty to use vanilla's impl; use isEmpty
|
2023-09-16 23:18:09 +02:00
|
|
|
return net.minecraft.world.item.ItemStack.EMPTY;
|
|
|
|
}
|
|
|
|
|