2021-06-11 14:02:28 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: chickeneer <emcchickeneer@gmail.com>
|
|
|
|
Date: Fri, 19 Mar 2021 00:33:15 -0500
|
|
|
|
Subject: [PATCH] Fix PlayerItemConsumeEvent cancelling properly
|
|
|
|
|
|
|
|
When the active item is not cleared, the item is still readied
|
|
|
|
for use and will repeatedly trigger the PlayerItemConsumeEvent
|
|
|
|
till their item is switched.
|
|
|
|
This patch clears the active item when the event is cancelled
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/entity/LivingEntity.java b/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.
Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.
Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.
Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.
Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-19 07:34:32 +01:00
|
|
|
index 6b5d8328ae9ce819f6ff1b9ba109a67ce8f121e8..123f9a7675c1f194273fff0fdd804cb6ab409201 100644
|
2021-06-11 14:02:28 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
2024-11-04 18:42:38 +01:00
|
|
|
@@ -4142,6 +4142,7 @@ public abstract class LivingEntity extends Entity implements Attackable {
|
2024-10-31 12:44:02 +01:00
|
|
|
}
|
|
|
|
entityPlayer.getBukkitEntity().updateInventory();
|
|
|
|
entityPlayer.getBukkitEntity().updateScaledHealth();
|
2023-06-08 03:13:54 +02:00
|
|
|
+ this.stopUsingItem(); // Paper - event is using an item, clear active item to reset its use
|
2024-10-31 12:44:02 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|