2022-02-03 03:44:57 +01:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
|
|
|
|
Date: Tue, 1 Feb 2022 15:51:55 -0700
|
|
|
|
Subject: [PATCH] API for creating command sender which forwards feedback
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/io/papermc/paper/commands/FeedbackForwardingSender.java b/src/main/java/io/papermc/paper/commands/FeedbackForwardingSender.java
|
|
|
|
new file mode 100644
|
2022-06-08 16:29:32 +02:00
|
|
|
index 0000000000000000000000000000000000000000..e3a5f1ec376319bdfda87fa27ae217bff3914292
|
2022-02-03 03:44:57 +01:00
|
|
|
--- /dev/null
|
|
|
|
+++ b/src/main/java/io/papermc/paper/commands/FeedbackForwardingSender.java
|
2022-06-08 15:38:56 +02:00
|
|
|
@@ -0,0 +1,111 @@
|
2022-02-03 03:44:57 +01:00
|
|
|
+package io.papermc.paper.commands;
|
|
|
|
+
|
|
|
|
+import io.papermc.paper.adventure.PaperAdventure;
|
|
|
|
+import java.util.UUID;
|
|
|
|
+import java.util.function.Consumer;
|
|
|
|
+import net.kyori.adventure.audience.MessageType;
|
|
|
|
+import net.kyori.adventure.identity.Identity;
|
|
|
|
+import net.kyori.adventure.text.Component;
|
2022-05-26 21:12:14 +02:00
|
|
|
+import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
|
2022-02-03 03:44:57 +01:00
|
|
|
+import net.minecraft.commands.CommandSource;
|
|
|
|
+import net.minecraft.commands.CommandSourceStack;
|
|
|
|
+import net.minecraft.server.level.ServerLevel;
|
|
|
|
+import net.minecraft.world.phys.Vec2;
|
|
|
|
+import net.minecraft.world.phys.Vec3;
|
|
|
|
+import org.bukkit.command.CommandSender;
|
|
|
|
+import org.bukkit.craftbukkit.CraftServer;
|
|
|
|
+import org.bukkit.craftbukkit.command.ServerCommandSender;
|
|
|
|
+import org.checkerframework.checker.nullness.qual.NonNull;
|
|
|
|
+import org.checkerframework.checker.nullness.qual.Nullable;
|
|
|
|
+import org.checkerframework.framework.qual.DefaultQualifier;
|
|
|
|
+
|
|
|
|
+@DefaultQualifier(NonNull.class)
|
|
|
|
+public final class FeedbackForwardingSender extends ServerCommandSender {
|
|
|
|
+ private final Consumer<? super Component> feedback;
|
|
|
|
+ private final CraftServer server;
|
|
|
|
+
|
|
|
|
+ public FeedbackForwardingSender(final Consumer<? super Component> feedback, final CraftServer server) {
|
|
|
|
+ super(((ServerCommandSender) server.getConsoleSender()).perm);
|
|
|
|
+ this.server = server;
|
|
|
|
+ this.feedback = feedback;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public void sendMessage(final String message) {
|
2022-05-26 21:12:14 +02:00
|
|
|
+ this.sendMessage(LegacyComponentSerializer.legacySection().deserialize(message));
|
2022-02-03 03:44:57 +01:00
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public void sendMessage(final String... messages) {
|
|
|
|
+ for (final String message : messages) {
|
|
|
|
+ this.sendMessage(message);
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public void sendMessage(final Identity identity, final Component message, final MessageType type) {
|
|
|
|
+ this.feedback.accept(message);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public String getName() {
|
|
|
|
+ return "FeedbackForwardingSender";
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public Component name() {
|
|
|
|
+ return Component.text(this.getName());
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public boolean isOp() {
|
|
|
|
+ return true;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public void setOp(final boolean value) {
|
|
|
|
+ throw new UnsupportedOperationException("Cannot change operator status of " + this.getClass().getName());
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ public CommandSourceStack asVanilla() {
|
|
|
|
+ final @Nullable ServerLevel overworld = this.server.getServer().overworld();
|
|
|
|
+ return new CommandSourceStack(
|
|
|
|
+ new Source(this),
|
|
|
|
+ overworld == null ? Vec3.ZERO : Vec3.atLowerCornerOf(overworld.getSharedSpawnPos()),
|
|
|
|
+ Vec2.ZERO,
|
|
|
|
+ overworld,
|
|
|
|
+ 4,
|
|
|
|
+ this.getName(),
|
2022-06-08 15:38:56 +02:00
|
|
|
+ net.minecraft.network.chat.Component.literal(this.getName()),
|
2022-02-03 03:44:57 +01:00
|
|
|
+ this.server.getServer(),
|
|
|
|
+ null
|
|
|
|
+ );
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ private record Source(FeedbackForwardingSender sender) implements CommandSource {
|
|
|
|
+ @Override
|
2022-06-08 15:38:56 +02:00
|
|
|
+ public void sendSystemMessage(final net.minecraft.network.chat.Component message) {
|
|
|
|
+ this.sender.sendMessage(Identity.nil(), PaperAdventure.asAdventure(message));
|
2022-02-03 03:44:57 +01:00
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public boolean acceptsSuccess() {
|
|
|
|
+ return true;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public boolean acceptsFailure() {
|
|
|
|
+ return true;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public boolean shouldInformAdmins() {
|
|
|
|
+ return false;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public CommandSender getBukkitSender(final CommandSourceStack stack) {
|
|
|
|
+ return this.sender;
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+}
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.
Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.
Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.
Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.
Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-19 07:34:32 +01:00
|
|
|
index 62ab88e022230d25ffb359981ce7da4e64a9be5a..3b01907bc119853e0676e912e9a29b05d9aa5763 100644
|
2022-02-03 03:44:57 +01:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
|
2024-10-27 18:11:15 +01:00
|
|
|
@@ -2165,6 +2165,13 @@ public final class CraftServer implements Server {
|
2023-10-27 01:34:58 +02:00
|
|
|
return this.console.console;
|
2022-02-03 03:44:57 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
+ // Paper start
|
|
|
|
+ @Override
|
|
|
|
+ public CommandSender createCommandSender(final java.util.function.Consumer<? super net.kyori.adventure.text.Component> feedback) {
|
|
|
|
+ return new io.papermc.paper.commands.FeedbackForwardingSender(feedback, this);
|
|
|
|
+ }
|
|
|
|
+ // Paper end
|
|
|
|
+
|
|
|
|
public EntityMetadataStore getEntityMetadata() {
|
|
|
|
return this.entityMetadata;
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/command/ServerCommandSender.java b/src/main/java/org/bukkit/craftbukkit/command/ServerCommandSender.java
|
2023-12-25 23:51:56 +01:00
|
|
|
index 7f22950ae61436e91a59cd29a345809c42bbe739..1e3091687735b461d3b6a313ab8761127981d3e8 100644
|
2022-02-03 03:44:57 +01:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/command/ServerCommandSender.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/command/ServerCommandSender.java
|
2023-12-25 23:51:56 +01:00
|
|
|
@@ -12,7 +12,7 @@ import org.bukkit.permissions.PermissionAttachmentInfo;
|
|
|
|
import org.bukkit.plugin.Plugin;
|
2022-02-03 03:44:57 +01:00
|
|
|
|
|
|
|
public abstract class ServerCommandSender implements CommandSender {
|
|
|
|
- private final PermissibleBase perm;
|
|
|
|
+ public final PermissibleBase perm; // Paper
|
|
|
|
private net.kyori.adventure.pointer.Pointers adventure$pointers; // Paper - implement pointers
|
|
|
|
|
2023-12-25 23:51:56 +01:00
|
|
|
protected ServerCommandSender() {
|
2022-02-03 03:44:57 +01:00
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/command/VanillaCommandWrapper.java b/src/main/java/org/bukkit/craftbukkit/command/VanillaCommandWrapper.java
|
Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.
Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.
Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.
Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.
Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-19 07:34:32 +01:00
|
|
|
index 35b05f9321ddbbbdf62f4bf726b58cf1205f0cfb..ce8683eff5b8ade57a2fcb77027cfe4b26986bc7 100644
|
2022-02-03 03:44:57 +01:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/command/VanillaCommandWrapper.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/command/VanillaCommandWrapper.java
|
2024-11-04 18:42:38 +01:00
|
|
|
@@ -86,6 +86,11 @@ public final class VanillaCommandWrapper extends BukkitCommand {
|
2022-02-03 03:44:57 +01:00
|
|
|
if (sender instanceof ProxiedCommandSender) {
|
|
|
|
return ((ProxiedNativeCommandSender) sender).getHandle();
|
|
|
|
}
|
|
|
|
+ // Paper start
|
|
|
|
+ if (sender instanceof io.papermc.paper.commands.FeedbackForwardingSender feedback) {
|
|
|
|
+ return feedback.asVanilla();
|
|
|
|
+ }
|
|
|
|
+ // Paper end
|
|
|
|
|
|
|
|
throw new IllegalArgumentException("Cannot make " + sender + " a vanilla command listener");
|
|
|
|
}
|