2023-06-13 01:51:45 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
|
|
|
Date: Fri, 9 Dec 2022 01:47:23 -0800
|
|
|
|
Subject: [PATCH] fix Instruments
|
|
|
|
|
|
|
|
properly handle Player#playNote
|
|
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
2024-01-19 17:54:05 +01:00
|
|
|
index 0dbb8d77b79ae2ae3aca4a96aeb92a981c07292a..73019b008afaa88d2e068ed4e8f006dfb1dbaf5f 100644
|
2023-06-13 01:51:45 +02:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
Updated Upstream (Bukkit/CraftBukkit) (#10034)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing
Bukkit Changes:
f29cb801 Separate checkstyle-suppressions file is not required
86f99bbe SPIGOT-7540, PR-946: Add ServerTickManager API
d4119585 SPIGOT-6903, PR-945: Add BlockData#getMapColor
b7a2ed41 SPIGOT-7530, PR-947: Add Player#removeResourcePack
9dd56255 SPIGOT-7527, PR-944: Add WindCharge#explode()
994a6163 Attempt upgrade of resolver libraries
CraftBukkit Changes:
b3b43a6ad Add Checkstyle check for unused imports
13fb3358e SPIGOT-7544: Scoreboard#getEntries() doesn't get entries but class names
3dda99c06 SPIGOT-7540, PR-1312: Add ServerTickManager API
2ab4508c0 SPIGOT-6903, PR-1311: Add BlockData#getMapColor
1dbdbbed4 PR-1238: Remove unnecessary sign ticking
659728d2a MC-264285, SPIGOT-7439, PR-1237: Fix unbreakable flint and steel is completely consumed while igniting creeper
e37e29ce0 Increase outdated build delay
c00438b39 SPIGOT-7530, PR-1313: Add Player#removeResourcePack
492dd80ce SPIGOT-7527, PR-1310: Add WindCharge#explode()
e11fbb9d7 Upgrade MySQL driver
9f3a0bd2a Attempt upgrade of resolver libraries
60d16d7ca PR-1306: Centralize Bukkit and Minecraft entity conversion
Spigot Changes:
06d602e7 Rebuild patches
2023-12-17 03:09:28 +01:00
|
|
|
@@ -724,7 +724,10 @@ public class CraftPlayer extends CraftHumanEntity implements Player {
|
2023-11-25 23:34:42 +01:00
|
|
|
Sound instrumentSound = instrument.getSound();
|
|
|
|
if (instrumentSound == null) return;
|
2023-06-13 01:51:45 +02:00
|
|
|
|
2023-11-25 23:34:42 +01:00
|
|
|
- float pitch = note.getPitch();
|
|
|
|
+ // Paper start - use correct pitch (modeled off of NoteBlock)
|
|
|
|
+ final net.minecraft.world.level.block.state.properties.NoteBlockInstrument noteBlockInstrument = CraftBlockData.toNMS(instrument, net.minecraft.world.level.block.state.properties.NoteBlockInstrument.class);
|
|
|
|
+ final float pitch = noteBlockInstrument.isTunable() ? note.getPitch() : 1.0f;
|
2023-06-13 01:51:45 +02:00
|
|
|
+ // Paper end
|
2023-11-25 23:34:42 +01:00
|
|
|
this.getHandle().connection.send(new ClientboundSoundPacket(CraftSound.bukkitToMinecraftHolder(instrumentSound), net.minecraft.sounds.SoundSource.RECORDS, loc.getBlockX(), loc.getBlockY(), loc.getBlockZ(), 3.0f, pitch, this.getHandle().getRandom().nextLong()));
|
2023-06-13 01:51:45 +02:00
|
|
|
}
|
|
|
|
|
2023-11-25 23:34:42 +01:00
|
|
|
diff --git a/src/test/java/io/papermc/paper/block/InstrumentSoundTest.java b/src/test/java/io/papermc/paper/block/InstrumentSoundTest.java
|
|
|
|
new file mode 100644
|
|
|
|
index 0000000000000000000000000000000000000000..28fc01045675247e75438bdc039fb8a90493419f
|
|
|
|
--- /dev/null
|
|
|
|
+++ b/src/test/java/io/papermc/paper/block/InstrumentSoundTest.java
|
|
|
|
@@ -0,0 +1,27 @@
|
|
|
|
+package io.papermc.paper.block;
|
|
|
|
+
|
|
|
|
+import java.util.Arrays;
|
|
|
|
+import java.util.stream.Stream;
|
|
|
|
+import net.minecraft.world.level.block.state.properties.NoteBlockInstrument;
|
|
|
|
+import org.bukkit.Instrument;
|
|
|
|
+import org.bukkit.craftbukkit.CraftSound;
|
|
|
|
+import org.bukkit.craftbukkit.block.data.CraftBlockData;
|
|
|
|
+import org.bukkit.support.AbstractTestingBase;
|
|
|
|
+import org.junit.jupiter.params.ParameterizedTest;
|
|
|
|
+import org.junit.jupiter.params.provider.MethodSource;
|
|
|
|
+
|
|
|
|
+import static org.junit.jupiter.api.Assertions.assertEquals;
|
|
|
|
+
|
|
|
|
+class InstrumentSoundTest extends AbstractTestingBase {
|
|
|
|
+
|
|
|
|
+ static Stream<Instrument> bukkitInstruments() {
|
|
|
|
+ return Arrays.stream(Instrument.values()).filter(i -> i.getSound() != null);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @ParameterizedTest
|
|
|
|
+ @MethodSource("bukkitInstruments")
|
|
|
|
+ void checkInstrumentSound(final Instrument bukkit) {
|
|
|
|
+ final NoteBlockInstrument nms = CraftBlockData.toNMS(bukkit, NoteBlockInstrument.class);
|
|
|
|
+ assertEquals(nms.getSoundEvent(), CraftSound.bukkitToMinecraftHolder(bukkit.getSound()));
|
|
|
|
+ }
|
|
|
|
+}
|