Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-11-08 03:39:48 +01:00
Code Issues Projects Releases Wiki Activity
6c5117b21c
Paper/CraftBukkit-Patches/0148-More-effecient-RegionFile-zero-ing.patch

37 lines
1.4 KiB
Diff
Raw Normal View History

Patch rebuild.
2016-03-01 01:23:45 +01:00
From 630c07926fec1744af435452e552445389be028f Mon Sep 17 00:00:00 2001
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
From: Aikar <aikar@aikar.co>
Date: Sat, 29 Aug 2015 17:48:20 -0400
Subject: [PATCH] More effecient RegionFile zero'ing
Speeds up new Chunk Generation by using 2 4k block writes vs 2048 4 byte writes
more effecient than going in and out of native calls repeatedly.
diff --git a/src/main/java/net/minecraft/server/RegionFile.java b/src/main/java/net/minecraft/server/RegionFile.java
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
index 1cd8be8..4c39b54 100644
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
--- a/src/main/java/net/minecraft/server/RegionFile.java
+++ b/src/main/java/net/minecraft/server/RegionFile.java
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
@@ -17,7 +17,7 @@ import java.util.zip.InflaterInputStream;
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
public class RegionFile {
- private static final byte[] a = new byte[4096];
+ private static final byte[] a = new byte[4096]; // Spigot - note: if this ever changes to not be 4096 bytes, update constructor! // PAIL: empty 4k block
private final File b;
private RandomAccessFile c;
private final int[] d = new int[1024];
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
@@ -37,8 +37,9 @@ public class RegionFile {
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
this.c = new RandomAccessFile(file, "rw");
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
if (this.c.length() < 4096L) {
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
- this.c.write(RegionFile.a);
- this.c.write(RegionFile.a);
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
+ // Spigot - more effecient chunk zero'ing
+ this.c.write(RegionFile.a); // Spigot
+ this.c.write(RegionFile.a); // Spigot
this.g += 8192;
}
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
--
Update to Minecraft 1.9
2016-02-29 22:33:06 +01:00
2.5.0
Optimize Chunk Saving Memory Allocation and Compression Minecraft ineffeciently uses OutputStreams by calling .write(int) on the stream. For Chunks, this is a DeflaterOutputStream, which allocates a single byte EVERY write. This is causing the server to allocate tons of new byte[1] objects. Additionally, this is very ineffecient for the Deflate process. By Buffering Writes the same way it already is Buffering Reads, we will write to the stream much more effeciently. Also a more effecient RegionFile zero'ing for new chunks to speed up new chunk generation.
2015-09-10 02:48:46 +02:00
Reference in New Issue Copy Permalink