Paper/patches/server/0394-Improve-Legacy-Component-serialization-size.patch

57 lines
3.5 KiB
Diff
Raw Normal View History

2021-06-11 14:02:28 +02:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Sun, 28 Jun 2020 19:08:41 -0400
Subject: [PATCH] Improve Legacy Component serialization size
Don't constantly send format: false for all formatting options when parent already
has it false
diff --git a/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java b/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java
index 516b3fef4d388366df09f0dd88deadbcc0b7d344..753200057e74b8e2d5274894b982e6ee946a559e 100644
2021-06-11 14:02:28 +02:00
--- a/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java
+++ b/src/main/java/org/bukkit/craftbukkit/util/CraftChatMessage.java
2023-12-05 23:55:31 +01:00
@@ -46,6 +46,7 @@ public final class CraftChatMessage {
2021-06-11 14:02:28 +02:00
// Separate pattern with no group 3, new lines are part of previous string
private static final Pattern INCREMENTAL_PATTERN_KEEP_NEWLINES = Pattern.compile("(" + String.valueOf(org.bukkit.ChatColor.COLOR_CHAR) + "[0-9a-fk-orx])|((?:(?:https?):\\/\\/)?(?:[-\\w_\\.]{2,}\\.[a-z]{2,4}.*?(?=[\\.\\?!,;:]?(?:[" + String.valueOf(org.bukkit.ChatColor.COLOR_CHAR) + " ]|$))))", Pattern.CASE_INSENSITIVE);
// ChatColor.b does not explicitly reset, its more of empty
+ private static final Style EMPTY = Style.EMPTY.withItalic(false); // Paper - Improve Legacy Component serialization size
private static final Style RESET = Style.EMPTY.withBold(false).withItalic(false).withUnderlined(false).withStrikethrough(false).withObfuscated(false);
2021-06-11 14:02:28 +02:00
private final List<Component> list = new ArrayList<Component>();
2023-12-05 23:55:31 +01:00
@@ -67,6 +68,7 @@ public final class CraftChatMessage {
Matcher matcher = (keepNewlines ? StringMessage.INCREMENTAL_PATTERN_KEEP_NEWLINES : StringMessage.INCREMENTAL_PATTERN).matcher(message);
2021-06-11 14:02:28 +02:00
String match = null;
boolean needsAdd = false;
+ boolean hasReset = false; // Paper - Improve Legacy Component serialization size
2021-06-11 14:02:28 +02:00
while (matcher.find()) {
int groupId = 0;
while ((match = matcher.group(++groupId)) == null) {
2023-12-05 23:55:31 +01:00
@@ -112,7 +114,26 @@ public final class CraftChatMessage {
2021-06-11 14:02:28 +02:00
throw new AssertionError("Unexpected message format");
}
} else { // Color resets formatting
- this.modifier = StringMessage.RESET.withColor(format);
+ // Paper start - Improve Legacy Component serialization size
2021-06-11 14:02:28 +02:00
+ Style previous = modifier;
+ modifier = (!hasReset ? RESET : EMPTY).withColor(format);
+ hasReset = true;
+ if (previous.isBold()) {
+ modifier = modifier.withBold(false);
+ }
+ if (previous.isItalic()) {
+ modifier = modifier.withItalic(false);
+ }
+ if (previous.isObfuscated()) {
+ modifier = modifier.withObfuscated(false);
2021-06-11 14:02:28 +02:00
+ }
+ if (previous.isStrikethrough()) {
+ modifier = modifier.withStrikethrough(false);
2021-06-11 14:02:28 +02:00
+ }
+ if (previous.isUnderlined()) {
+ modifier = modifier.withUnderlined(false);
2021-06-11 14:02:28 +02:00
+ }
+ // Paper end - Improve Legacy Component serialization size
2021-06-11 14:02:28 +02:00
}
needsAdd = true;
break;