2021-08-13 00:55:41 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Andrew Steinborn <git@steinborn.me>
|
|
|
|
Date: Mon, 9 Aug 2021 00:38:37 -0400
|
|
|
|
Subject: [PATCH] Optimize indirect passenger iteration
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/entity/Entity.java b/src/main/java/net/minecraft/world/entity/Entity.java
|
2024-01-21 12:53:04 +01:00
|
|
|
index e6142fc4ac6fe6149f6094124223cdebd56e7b76..2b34c7bc49fff37b6e0a603b6670103fe959fe2a 100644
|
2021-08-13 00:55:41 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/entity/Entity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/entity/Entity.java
|
2024-01-21 12:53:04 +01:00
|
|
|
@@ -3924,20 +3924,34 @@ public abstract class Entity implements Nameable, EntityAccess, CommandSource, S
|
2021-08-13 00:55:41 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
private Stream<Entity> getIndirectPassengersStream() {
|
2024-01-19 13:22:30 +01:00
|
|
|
+ if (this.passengers.isEmpty()) { return Stream.of(); } // Paper - Optimize indirect passenger iteration
|
2021-08-14 12:01:07 +02:00
|
|
|
return this.passengers.stream().flatMap(Entity::getSelfAndPassengers);
|
2021-08-13 00:55:41 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
@Override
|
|
|
|
public Stream<Entity> getSelfAndPassengers() {
|
2024-01-19 13:22:30 +01:00
|
|
|
+ if (this.passengers.isEmpty()) { return Stream.of(this); } // Paper - Optimize indirect passenger iteration
|
2021-08-13 00:55:41 +02:00
|
|
|
return Stream.concat(Stream.of(this), this.getIndirectPassengersStream());
|
|
|
|
}
|
|
|
|
|
|
|
|
@Override
|
|
|
|
public Stream<Entity> getPassengersAndSelf() {
|
2024-01-19 13:22:30 +01:00
|
|
|
+ if (this.passengers.isEmpty()) { return Stream.of(this); } // Paper - Optimize indirect passenger iteration
|
2021-08-13 00:55:41 +02:00
|
|
|
return Stream.concat(this.passengers.stream().flatMap(Entity::getPassengersAndSelf), Stream.of(this));
|
|
|
|
}
|
|
|
|
|
|
|
|
public Iterable<Entity> getIndirectPassengers() {
|
2024-01-19 13:22:30 +01:00
|
|
|
+ // Paper start - Optimize indirect passenger iteration
|
2021-08-13 00:55:41 +02:00
|
|
|
+ if (this.passengers.isEmpty()) { return ImmutableList.of(); }
|
|
|
|
+ ImmutableList.Builder<Entity> indirectPassengers = ImmutableList.builder();
|
|
|
|
+ for (Entity passenger : this.passengers) {
|
|
|
|
+ indirectPassengers.add(passenger);
|
|
|
|
+ indirectPassengers.addAll(passenger.getIndirectPassengers());
|
|
|
|
+ }
|
|
|
|
+ return indirectPassengers.build();
|
|
|
|
+ }
|
|
|
|
+ private Iterable<Entity> getIndirectPassengers_old() {
|
2024-01-19 13:22:30 +01:00
|
|
|
+ // Paper end - Optimize indirect passenger iteration
|
2021-08-13 00:55:41 +02:00
|
|
|
return () -> {
|
|
|
|
return this.getIndirectPassengersStream().iterator();
|
|
|
|
};
|
2024-01-21 12:53:04 +01:00
|
|
|
@@ -3960,6 +3974,7 @@ public abstract class Entity implements Nameable, EntityAccess, CommandSource, S
|
2023-09-22 22:13:57 +02:00
|
|
|
// Paper end - rewrite chunk system
|
2021-08-13 00:55:41 +02:00
|
|
|
|
|
|
|
public boolean hasExactlyOnePlayerPassenger() {
|
2024-01-19 13:22:30 +01:00
|
|
|
+ if (this.passengers.isEmpty()) { return false; } // Paper - Optimize indirect passenger iteration
|
2023-12-06 04:57:46 +01:00
|
|
|
return this.countPlayerPassengers() == 1;
|
|
|
|
}
|
|
|
|
|