Paper/Spigot-Server-Patches/0326-Fix-sign-edit-memory-leak.patch

45 lines
2.2 KiB
Diff
Raw Normal View History

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2019-02-28 06:47:57 +01:00
From: Aikar <aikar@aikar.co>
Date: Thu, 28 Feb 2019 00:15:28 -0500
Subject: [PATCH] Fix sign edit memory leak
when a player edits a sign, a reference to their Entity is never cleand up.
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
index 07c42d062e6618f47afc9a35ae53277527ef7379..1705e223ec913b02793f2c329ff9401fbcf08178 100644
2019-02-28 06:47:57 +01:00
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
@@ -2684,7 +2684,7 @@ public class PlayerConnection implements PacketListenerPlayIn {
2019-02-28 06:47:57 +01:00
TileEntitySign tileentitysign = (TileEntitySign) tileentity;
2019-05-28 01:01:45 +02:00
- if (!tileentitysign.d() || tileentitysign.f() != this.player) {
+ if (!tileentitysign.d() || tileentitysign.signEditor == null || !tileentitysign.signEditor.equals(this.player.getUniqueID())) {
2020-06-25 16:09:55 +02:00
PlayerConnection.LOGGER.warn("Player {} just tried to change non-editable sign", this.player.getDisplayName().getString());
2019-02-28 06:47:57 +01:00
this.sendPacket(tileentity.getUpdatePacket()); // CraftBukkit
return;
diff --git a/src/main/java/net/minecraft/server/TileEntitySign.java b/src/main/java/net/minecraft/server/TileEntitySign.java
index 2b249e7e2018a283b80b9462fbc129420e47ec06..7bee21d9ae9e8c27fe129605060455b55093afda 100644
2019-02-28 06:47:57 +01:00
--- a/src/main/java/net/minecraft/server/TileEntitySign.java
+++ b/src/main/java/net/minecraft/server/TileEntitySign.java
2020-06-25 16:09:55 +02:00
@@ -11,6 +11,7 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
private EntityHuman c;
private final FormattedString[] g;
private EnumColor color;
+ public java.util.UUID signEditor; // Paper
2019-02-28 06:47:57 +01:00
public TileEntitySign() {
super(TileEntityTypes.SIGN);
2020-06-25 16:09:55 +02:00
@@ -112,7 +113,10 @@ public class TileEntitySign extends TileEntity implements ICommandListener { //
2019-02-28 06:47:57 +01:00
}
public void a(EntityHuman entityhuman) {
- this.c = entityhuman;
2019-02-28 06:47:57 +01:00
+ // Paper start
+ //this.c = entityhuman;
2019-02-28 06:47:57 +01:00
+ signEditor = entityhuman != null ? entityhuman.getUniqueID() : null;
+ // Paper end
}
2019-05-28 01:01:45 +02:00
public EntityHuman f() {