2020-04-19 12:01:07 +02:00
|
|
|
From 0c8abbef973ff237353efdbb1d21a8c66eac9fd3 Mon Sep 17 00:00:00 2001
|
2020-04-09 03:36:10 +02:00
|
|
|
From: Aikar <aikar@aikar.co>
|
|
|
|
Date: Wed, 8 Apr 2020 21:24:05 -0400
|
|
|
|
Subject: [PATCH] Increase Light Queue Size
|
|
|
|
|
|
|
|
Wiz mentioned that large WorldEdit operations cause light to run on
|
|
|
|
main thread. The queue was small, set to 5.. this bumps it to 20
|
|
|
|
but makes it configurable per-world.
|
|
|
|
|
|
|
|
The main risk of increasing this higher is during shutdown, some
|
|
|
|
queued light updates may be lost because mojang did not flush the
|
|
|
|
light engine on shutdown...
|
|
|
|
|
|
|
|
The queue size only puts a cap on max loss, doesn't solve that problem.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
index 659a011e97..88a45e517c 100644
|
|
|
|
--- a/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
+++ b/src/main/java/com/destroystokyo/paper/PaperWorldConfig.java
|
|
|
|
@@ -684,4 +684,9 @@ public class PaperWorldConfig {
|
|
|
|
private void trackerUpdateDistance() {
|
|
|
|
trackerUpdateDistance = getDouble("tracker-update-distance", trackerUpdateDistance);
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public int lightQueueSize = 20;
|
|
|
|
+ private void lightQueueSize() {
|
|
|
|
+ lightQueueSize = getInt("light-queue-size", lightQueueSize);
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2020-04-19 12:01:07 +02:00
|
|
|
index ec9ff06cf5..e35bacac71 100644
|
2020-04-09 03:36:10 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2020-04-19 12:01:07 +02:00
|
|
|
@@ -637,7 +637,7 @@ public abstract class MinecraftServer extends IAsyncTaskHandlerReentrant<TickTas
|
2020-04-09 03:36:10 +02:00
|
|
|
this.executeModerately();
|
|
|
|
// CraftBukkit end
|
|
|
|
worldloadlistener.b();
|
|
|
|
- chunkproviderserver.getLightEngine().a(5);
|
|
|
|
+ chunkproviderserver.getLightEngine().a(worldserver.paperConfig.lightQueueSize); // Paper - increase light queue size
|
|
|
|
|
|
|
|
// CraftBukkit start
|
|
|
|
this.forceTicks = false;
|
|
|
|
--
|
|
|
|
2.25.1
|
|
|
|
|