2021-06-14 18:58:00 +02:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Jake Potrebic <jake.m.potrebic@gmail.com>
|
|
|
|
Date: Wed, 24 Jun 2020 12:39:08 -0600
|
|
|
|
Subject: [PATCH] Beacon API - custom effect ranges
|
|
|
|
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/level/block/entity/BeaconBlockEntity.java b/src/main/java/net/minecraft/world/level/block/entity/BeaconBlockEntity.java
|
Updated Upstream (Bukkit/CraftBukkit) (#10242)
* Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing
Bukkit Changes:
a6a9d2a4 Remove some old ApiStatus.Experimental annotations
be72314c SPIGOT-7300, PR-829: Add new DamageSource API providing enhanced information about entity damage
b252cf05 SPIGOT-7576, PR-970: Add methods in MushroomCow to change stew effects
b1c689bd PR-902: Add Server#isLoggingIPs to get log-ips configuration
08f86d1c PR-971: Add Player methods for client-side potion effects
2e3024a9 PR-963: Add API for in-world structures
a23292a7 SPIGOT-7530, PR-948: Improve Resource Pack API with new 1.20.3 functionality
1851857b SPIGOT-3071, PR-969: Add entity spawn method with spawn reason
cde4c52a SPIGOT-5553, PR-964: Add EntityKnockbackEvent
CraftBukkit Changes:
38fd4bd50 Fix accidentally renamed internal damage method
80f0ce4be SPIGOT-7300, PR-1180: Add new DamageSource API providing enhanced information about entity damage
7e43f3b16 SPIGOT-7581: Fix typo in BlockMushroom
ea14b7d90 SPIGOT-7576, PR-1347: Add methods in MushroomCow to change stew effects
4c687f243 PR-1259: Add Server#isLoggingIPs to get log-ips configuration
22a541a29 Improve support for per-world game rules
cb7dccce2 PR-1348: Add Player methods for client-side potion effects
b8d6109f0 PR-1335: Add API for in-world structures
4398a1b5b SPIGOT-7577: Make CraftWindCharge#explode discard the entity
e74107678 Fix Crafter maximum stack size
0bb0f4f6a SPIGOT-7530, PR-1314: Improve Resource Pack API with new 1.20.3 functionality
4949f556d SPIGOT-3071, PR-1345: Add entity spawn method with spawn reason
20ac73ca2 PR-1353: Fix Structure#place not working as documented with 0 palette
3c1b77871 SPIGOT-6911, PR-1349: Change max book length in CraftMetaBook
333701839 SPIGOT-7572: Bee nests generated without bees
f48f4174c SPIGOT-5553, PR-1336: Add EntityKnockbackEvent
2024-02-11 22:28:00 +01:00
|
|
|
index a1097950766ad31393340b423ea3f98a1f555368..49f25826aea528d9da085b9e65cb4c85cd78c415 100644
|
2021-06-14 18:58:00 +02:00
|
|
|
--- a/src/main/java/net/minecraft/world/level/block/entity/BeaconBlockEntity.java
|
|
|
|
+++ b/src/main/java/net/minecraft/world/level/block/entity/BeaconBlockEntity.java
|
2023-09-22 06:40:51 +02:00
|
|
|
@@ -82,6 +82,26 @@ public class BeaconBlockEntity extends BlockEntity implements MenuProvider, Name
|
2021-06-14 18:58:00 +02:00
|
|
|
return (BeaconBlockEntity.hasSecondaryEffect(this.levels, this.primaryPower, this.secondaryPower)) ? CraftPotionUtil.toBukkit(new MobEffectInstance(this.secondaryPower, BeaconBlockEntity.getLevel(this.levels), BeaconBlockEntity.getAmplification(this.levels, this.primaryPower, this.secondaryPower), true, true)) : null;
|
|
|
|
}
|
|
|
|
// CraftBukkit end
|
2024-01-20 12:50:16 +01:00
|
|
|
+ // Paper start - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
+ private final String PAPER_RANGE_TAG = "Paper.Range";
|
|
|
|
+ private double effectRange = -1;
|
|
|
|
+
|
|
|
|
+ public double getEffectRange() {
|
|
|
|
+ if (this.effectRange < 0) {
|
|
|
|
+ return this.levels * 10 + 10;
|
|
|
|
+ } else {
|
|
|
|
+ return effectRange;
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ public void setEffectRange(double range) {
|
|
|
|
+ this.effectRange = range;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ public void resetEffectRange() {
|
|
|
|
+ this.effectRange = -1;
|
|
|
|
+ }
|
2024-01-20 12:50:16 +01:00
|
|
|
+ // Paper end - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
|
2023-09-22 06:40:51 +02:00
|
|
|
@Nullable
|
|
|
|
static MobEffect filterEffect(@Nullable MobEffect effect) {
|
|
|
|
@@ -197,7 +217,7 @@ public class BeaconBlockEntity extends BlockEntity implements MenuProvider, Name
|
2021-07-02 21:51:49 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (blockEntity.levels > 0 && !blockEntity.beamSections.isEmpty()) {
|
|
|
|
- BeaconBlockEntity.applyEffects(world, pos, blockEntity.levels, blockEntity.primaryPower, blockEntity.secondaryPower);
|
2024-01-20 12:50:16 +01:00
|
|
|
+ BeaconBlockEntity.applyEffects(world, pos, blockEntity.levels, blockEntity.primaryPower, blockEntity.secondaryPower, blockEntity); // Paper - Custom beacon ranges
|
2021-07-02 21:51:49 +02:00
|
|
|
BeaconBlockEntity.playSound(world, pos, SoundEvents.BEACON_AMBIENT);
|
|
|
|
}
|
|
|
|
}
|
2023-09-22 06:40:51 +02:00
|
|
|
@@ -283,8 +303,13 @@ public class BeaconBlockEntity extends BlockEntity implements MenuProvider, Name
|
2021-06-14 18:58:00 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
public static List getHumansInRange(Level world, BlockPos blockposition, int i) {
|
2024-01-20 12:50:16 +01:00
|
|
|
+ // Paper start - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
+ return BeaconBlockEntity.getHumansInRange(world, blockposition, i, null);
|
|
|
|
+ }
|
|
|
|
+ public static List getHumansInRange(Level world, BlockPos blockposition, int i, @Nullable BeaconBlockEntity blockEntity) {
|
2024-01-20 12:50:16 +01:00
|
|
|
+ // Paper end - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
{
|
|
|
|
- double d0 = (double) (i * 10 + 10);
|
2024-01-20 23:13:41 +01:00
|
|
|
+ double d0 = blockEntity != null ? blockEntity.getEffectRange() : (i * 10 + 10); // Paper - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
|
|
|
|
AABB axisalignedbb = (new AABB(blockposition)).inflate(d0).expandTowards(0.0D, (double) world.getHeight(), 0.0D);
|
|
|
|
List<Player> list = world.getEntitiesOfClass(Player.class, axisalignedbb);
|
2023-09-22 06:40:51 +02:00
|
|
|
@@ -325,12 +350,17 @@ public class BeaconBlockEntity extends BlockEntity implements MenuProvider, Name
|
2021-07-02 21:51:49 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
private static void applyEffects(Level world, BlockPos pos, int beaconLevel, @Nullable MobEffect primaryEffect, @Nullable MobEffect secondaryEffect) {
|
2024-01-20 12:50:16 +01:00
|
|
|
+ // Paper start - Custom beacon ranges
|
2021-07-02 21:51:49 +02:00
|
|
|
+ BeaconBlockEntity.applyEffects(world, pos, beaconLevel, primaryEffect, secondaryEffect, null);
|
|
|
|
+ }
|
|
|
|
+ private static void applyEffects(Level world, BlockPos pos, int beaconLevel, @Nullable MobEffect primaryEffect, @Nullable MobEffect secondaryEffect, @Nullable BeaconBlockEntity blockEntity) {
|
2024-01-20 12:50:16 +01:00
|
|
|
+ // Paper end - Custom beacon ranges
|
2021-07-02 21:51:49 +02:00
|
|
|
if (!world.isClientSide && primaryEffect != null) {
|
|
|
|
double d0 = (double) (beaconLevel * 10 + 10);
|
|
|
|
byte b0 = BeaconBlockEntity.getAmplification(beaconLevel, primaryEffect, secondaryEffect);
|
|
|
|
|
|
|
|
int j = BeaconBlockEntity.getLevel(beaconLevel);
|
|
|
|
- List list = BeaconBlockEntity.getHumansInRange(world, pos, beaconLevel);
|
2024-01-20 12:50:16 +01:00
|
|
|
+ List list = BeaconBlockEntity.getHumansInRange(world, pos, beaconLevel, blockEntity); // Paper - Custom beacon ranges
|
2021-07-02 21:51:49 +02:00
|
|
|
|
|
|
|
BeaconBlockEntity.applyEffect(list, primaryEffect, j, b0, true, pos); // Paper - BeaconEffectEvent
|
|
|
|
|
2023-09-22 06:40:51 +02:00
|
|
|
@@ -393,6 +423,7 @@ public class BeaconBlockEntity extends BlockEntity implements MenuProvider, Name
|
2021-06-14 18:58:00 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
this.lockKey = LockCode.fromTag(nbt);
|
2024-01-20 12:50:16 +01:00
|
|
|
+ this.effectRange = nbt.contains(PAPER_RANGE_TAG, 6) ? nbt.getDouble(PAPER_RANGE_TAG) : -1; // Paper - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
@Override
|
2023-09-22 06:40:51 +02:00
|
|
|
@@ -406,6 +437,7 @@ public class BeaconBlockEntity extends BlockEntity implements MenuProvider, Name
|
2021-06-14 18:58:00 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
this.lockKey.addToTag(nbt);
|
2024-01-20 12:50:16 +01:00
|
|
|
+ nbt.putDouble(PAPER_RANGE_TAG, this.effectRange); // Paper - Custom beacon ranges
|
2021-06-14 18:58:00 +02:00
|
|
|
}
|
|
|
|
|
2021-11-24 17:39:04 +01:00
|
|
|
public void setCustomName(@Nullable Component customName) {
|
2021-06-14 18:58:00 +02:00
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftBeacon.java b/src/main/java/org/bukkit/craftbukkit/block/CraftBeacon.java
|
2024-01-20 12:50:16 +01:00
|
|
|
index c4890927419e27fd35e4e373fb09dcb182234fbf..2d77ee30f87491bd413d11687d9fd6def843104c 100644
|
2021-06-14 18:58:00 +02:00
|
|
|
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftBeacon.java
|
|
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftBeacon.java
|
2023-09-29 02:28:26 +02:00
|
|
|
@@ -32,7 +32,7 @@ public class CraftBeacon extends CraftBlockEntityState<BeaconBlockEntity> implem
|
2021-07-02 21:51:49 +02:00
|
|
|
if (tileEntity instanceof BeaconBlockEntity) {
|
|
|
|
BeaconBlockEntity beacon = (BeaconBlockEntity) tileEntity;
|
|
|
|
|
|
|
|
- Collection<Player> nms = BeaconBlockEntity.getHumansInRange(beacon.getLevel(), beacon.getBlockPos(), beacon.levels);
|
2024-01-20 12:50:16 +01:00
|
|
|
+ Collection<Player> nms = BeaconBlockEntity.getHumansInRange(beacon.getLevel(), beacon.getBlockPos(), beacon.levels, beacon); // Paper - Custom beacon ranges
|
2021-07-02 21:51:49 +02:00
|
|
|
Collection<LivingEntity> bukkit = new ArrayList<LivingEntity>(nms.size());
|
|
|
|
|
|
|
|
for (Player human : nms) {
|
2023-09-29 02:28:26 +02:00
|
|
|
@@ -114,4 +114,21 @@ public class CraftBeacon extends CraftBlockEntityState<BeaconBlockEntity> implem
|
|
|
|
public CraftBeacon copy() {
|
|
|
|
return new CraftBeacon(this);
|
2021-06-14 18:58:00 +02:00
|
|
|
}
|
|
|
|
+
|
|
|
|
+ // Paper start
|
|
|
|
+ @Override
|
|
|
|
+ public double getEffectRange() {
|
|
|
|
+ return this.getSnapshot().getEffectRange();
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public void setEffectRange(double range) {
|
|
|
|
+ this.getSnapshot().setEffectRange(range);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public void resetEffectRange() {
|
|
|
|
+ this.getSnapshot().resetEffectRange();
|
|
|
|
+ }
|
|
|
|
+ // Paper end
|
|
|
|
}
|