Paper/Spigot-Server-Patches/0059-Change-implementation-of-tile-entity-removal-list.patch

83 lines
3.5 KiB
Diff
Raw Normal View History

From bc94a21d1941e2d5d173d0be455acef7c1b02ce8 Mon Sep 17 00:00:00 2001
2016-03-01 00:09:49 +01:00
From: Joseph Hirschfeld <joe@ibj.io>
Date: Thu, 3 Mar 2016 02:39:54 -0600
Subject: [PATCH] Change implementation of (tile)entity removal list
2016-04-02 04:08:40 +02:00
diff --git a/src/main/java/net/minecraft/server/Entity.java b/src/main/java/net/minecraft/server/Entity.java
index aadc426fd..584501787 100644
2016-04-02 04:08:40 +02:00
--- a/src/main/java/net/minecraft/server/Entity.java
+++ b/src/main/java/net/minecraft/server/Entity.java
@@ -122,7 +122,7 @@ public abstract class Entity implements ICommandListener, KeyedObject { // Paper
2016-05-12 04:07:46 +02:00
private static final DataWatcherObject<Boolean> aC = DataWatcher.a(Entity.class, DataWatcherRegistry.h);
2016-06-09 05:57:14 +02:00
private static final DataWatcherObject<Boolean> aD = DataWatcher.a(Entity.class, DataWatcherRegistry.h);
2017-05-14 20:05:01 +02:00
private static final DataWatcherObject<Boolean> aE = DataWatcher.a(Entity.class, DataWatcherRegistry.h);
2016-11-17 03:23:38 +01:00
- public boolean aa;
+ public boolean aa; public boolean isAddedToChunk() { return aa; } // Paper - OBFHELPER
public int ab; public int getChunkX() { return ab; } // Paper - OBFHELPER
public int ac; public int getChunkY() { return ac; } // Paper - OBFHELPER
public int ad; public int getChunkZ() { return ad; } // Paper - OBFHELPER
2016-03-01 00:09:49 +01:00
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
index e85ed2e33..89197281e 100644
2016-03-01 00:09:49 +01:00
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
2017-08-03 16:36:06 +02:00
@@ -31,6 +31,11 @@ import org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason;
import org.bukkit.generator.ChunkGenerator;
// CraftBukkit end
+// Paper start
2016-03-01 00:09:49 +01:00
+import java.util.Set;
+import com.google.common.collect.Sets;
+// Paper end
+
public abstract class World implements IBlockAccess {
2016-03-01 00:09:49 +01:00
private int a = 63;
2017-08-03 16:36:06 +02:00
@@ -61,11 +66,11 @@ public abstract class World implements IBlockAccess {
2016-03-01 00:09:49 +01:00
}
};
// Spigot end
- protected final List<Entity> f = Lists.newArrayList();
+ protected final Set<Entity> f = Sets.newHashSet(); // Paper
public final List<TileEntity> tileEntityList = Lists.newArrayList();
2016-03-01 00:09:49 +01:00
public final List<TileEntity> tileEntityListTick = Lists.newArrayList();
private final List<TileEntity> b = Lists.newArrayList();
- private final List<TileEntity> tileEntityListUnload = Lists.newArrayList();
+ private final Set<TileEntity> tileEntityListUnload = Sets.newHashSet(); // Paper
public final List<EntityHuman> players = Lists.newArrayList();
public final List<Entity> j = Lists.newArrayList();
protected final IntHashMap<Entity> entitiesById = new IntHashMap();
2017-12-09 18:37:09 +01:00
@@ -1397,20 +1402,20 @@ public abstract class World implements IBlockAccess {
2016-06-09 05:57:14 +02:00
this.entityList.removeAll(this.f);
2016-03-01 00:09:49 +01:00
int j;
+ // Paper start - Set based removal lists
+ for (Entity e : this.f) {
2016-06-09 05:57:14 +02:00
+ j = e.getChunkZ();
+ int k = e.getChunkX();
2016-03-01 00:09:49 +01:00
2016-06-09 05:57:14 +02:00
- for (i = 0; i < this.f.size(); ++i) {
- entity = (Entity) this.f.get(i);
2016-11-17 03:23:38 +01:00
- int k = entity.ab;
2016-06-09 05:57:14 +02:00
-
2016-11-17 03:23:38 +01:00
- j = entity.ad;
- if (entity.aa && this.isChunkLoaded(k, j, true)) {
2016-03-01 00:09:49 +01:00
- this.getChunkAt(k, j).b(entity);
2016-06-09 05:57:14 +02:00
+ if (e.isAddedToChunk() && this.isChunkLoaded(k, j, true)) {
+ this.getChunkAt(k, j).b(e);
2016-03-01 00:09:49 +01:00
}
}
- for (i = 0; i < this.f.size(); ++i) {
- this.c((Entity) this.f.get(i));
+ for (Entity e : this.f) {
+ this.c(e);
}
+ // Paper end
this.f.clear();
this.l();
--
2.18.0
2016-03-01 00:09:49 +01:00