Paper/patches/server/0507-MC-4-Fix-item-position-desync.patch

51 lines
2.4 KiB
Diff
Raw Normal View History

2022-06-11 10:41:59 +02:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: BillyGalbreath <blake.galbreath@gmail.com>
Date: Tue, 8 Dec 2020 20:24:52 -0600
Subject: [PATCH] MC-4: Fix item position desync
This fixes item position desync (MC-4) by running the item coordinates
through the encode/decode methods of the packet that causes the precision
loss, which forces the server to lose the same precision as the client
keeping them in sync.
diff --git a/src/main/java/net/minecraft/network/protocol/game/VecDeltaCodec.java b/src/main/java/net/minecraft/network/protocol/game/VecDeltaCodec.java
2023-09-22 19:59:56 +02:00
index 05ac41e136da43284fb24a6b698ebd36318278fb..33d9131e9c75ef23cd637f5d6c39a2704a0c92a5 100644
2022-06-11 10:41:59 +02:00
--- a/src/main/java/net/minecraft/network/protocol/game/VecDeltaCodec.java
+++ b/src/main/java/net/minecraft/network/protocol/game/VecDeltaCodec.java
2022-12-07 21:16:54 +01:00
@@ -9,12 +9,12 @@ public class VecDeltaCodec {
2022-06-11 10:41:59 +02:00
2022-12-07 21:16:54 +01:00
@VisibleForTesting
static long encode(double value) {
- return Math.round(value * 4096.0D);
+ return Math.round(value * 4096.0D); // Paper - diff on change
2022-06-11 10:41:59 +02:00
}
2022-12-07 21:16:54 +01:00
@VisibleForTesting
static double decode(long value) {
2022-06-11 10:41:59 +02:00
- return (double)value / 4096.0D;
2022-12-07 21:16:54 +01:00
+ return (double)value / 4096.0D; // Paper - diff on change
2022-06-11 10:41:59 +02:00
}
public Vec3 decode(long x, long y, long z) {
diff --git a/src/main/java/net/minecraft/world/entity/Entity.java b/src/main/java/net/minecraft/world/entity/Entity.java
index 9257855651f7605935ecab121e239bef7218e53c..e8604fa9ef819db8a5f5fabc99022095bce7b00d 100644
2022-06-11 10:41:59 +02:00
--- a/src/main/java/net/minecraft/world/entity/Entity.java
+++ b/src/main/java/net/minecraft/world/entity/Entity.java
@@ -4227,6 +4227,16 @@ public abstract class Entity implements Nameable, EntityAccess, CommandSource {
2023-09-22 22:13:57 +02:00
return;
}
// Paper end - rewrite chunk system
2022-06-11 10:41:59 +02:00
+ // Paper start - fix MC-4
+ if (this instanceof ItemEntity) {
+ if (io.papermc.paper.configuration.GlobalConfiguration.get().misc.fixEntityPositionDesync) {
2022-06-11 11:02:09 +02:00
+ // encode/decode from ClientboundMoveEntityPacket
2022-06-11 10:41:59 +02:00
+ x = Mth.lfloor(x * 4096.0D) * (1 / 4096.0D);
+ y = Mth.lfloor(y * 4096.0D) * (1 / 4096.0D);
+ z = Mth.lfloor(z * 4096.0D) * (1 / 4096.0D);
+ }
+ }
+ // Paper end - fix MC-4
if (this.position.x != x || this.position.y != y || this.position.z != z) {
this.position = new Vec3(x, y, z);
int i = Mth.floor(x);