2021-06-11 14:02:28 +02:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Mon, 4 Mar 2013 23:46:10 -0500
Subject: [PATCH] Chunk Save Reattempt
We commonly have "Stream Closed" errors on chunk saving, so this code should re-try to save the chunk in the event of failure and hopefully prevent rollbacks.
diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
2024-01-24 13:07:40 +01:00
index 66994aa135037919219e0bbcabe7de9f6f2c9dcd..140d6e455c1729f6e31e95facba5520b75ad838c 100644
2021-06-11 14:02:28 +02:00
--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
+++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFile.java
2024-01-24 13:07:40 +01:00
@@ -274,7 +274,7 @@ public class RegionFile implements AutoCloseable {
2021-06-11 14:02:28 +02:00
return true;
}
} catch (IOException ioexception) {
2024-01-23 14:34:17 +01:00
- com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(ioexception); // Paper - ServerExceptionEvent
+ com.destroystokyo.paper.util.SneakyThrow.sneaky(ioexception); // Paper - Chunk save reattempt; we want the upper try/catch to retry this
2021-06-11 14:02:28 +02:00
return false;
}
}
diff --git a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
2024-01-24 14:05:59 +01:00
index 1988063a0cac0350ae3b3388b8f2a0c95b8b259f..50a285127ee5a247680d4486ec9d5e01453b8a8e 100644
2021-06-11 14:02:28 +02:00
--- a/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
+++ b/src/main/java/net/minecraft/world/level/chunk/storage/RegionFileStorage.java
2024-01-24 14:05:59 +01:00
@@ -132,6 +132,11 @@ public class RegionFileStorage implements AutoCloseable {
2024-01-24 13:07:40 +01:00
protected void write(ChunkPos pos, @Nullable CompoundTag nbt) throws IOException {
RegionFile regionfile = this.getRegionFile(pos, false); // CraftBukkit
+ // Paper start - Chunk save reattempt
+ int attempts = 0;
+ Exception lastException = null;
2024-01-24 14:05:59 +01:00
+ while (attempts++ < 5) { try {
2024-01-24 13:07:40 +01:00
+ // Paper end - Chunk save reattempt
2021-06-11 14:02:28 +02:00
2021-06-12 02:57:04 +02:00
if (nbt == null) {
regionfile.clear(pos);
2024-01-24 14:05:59 +01:00
@@ -156,7 +161,18 @@ public class RegionFileStorage implements AutoCloseable {
2022-09-01 18:51:59 +02:00
dataoutputstream.close();
2021-06-12 02:57:04 +02:00
}
2021-06-11 14:02:28 +02:00
}
2024-01-23 14:34:17 +01:00
+ // Paper start - Chunk save reattempt
2024-01-24 13:07:40 +01:00
+ return;
+ } catch (Exception ex) {
+ lastException = ex;
+ }
2021-06-11 14:02:28 +02:00
+ }
2022-09-01 18:51:59 +02:00
2024-01-24 13:07:40 +01:00
+ if (lastException != null) {
+ com.destroystokyo.paper.exception.ServerInternalException.reportInternalException(lastException);
+ net.minecraft.server.MinecraftServer.LOGGER.error("Failed to save chunk {}", pos, lastException);
2021-06-11 14:02:28 +02:00
+ }
2024-01-23 14:34:17 +01:00
+ // Paper end - Chunk save reattempt
2024-01-24 13:07:40 +01:00
}
public void close() throws IOException {