Paper/Spigot-Server-Patches/0127-Optimize-ItemStack.isEmpty.patch

21 lines
972 B
Diff
Raw Normal View History

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2018-07-17 22:32:05 +02:00
From: Aikar <aikar@aikar.co>
Date: Wed, 21 Dec 2016 03:48:29 -0500
Subject: [PATCH] Optimize ItemStack.isEmpty()
Remove hashMap lookup every check, simplify code to remove ternary
diff --git a/src/main/java/net/minecraft/server/ItemStack.java b/src/main/java/net/minecraft/server/ItemStack.java
index dce861df47403ae7f7c5f0f541f3f7abf0abe0cc..74de67380094261cb93264d760ddbbbd5cce8220 100644
2018-07-17 22:32:05 +02:00
--- a/src/main/java/net/minecraft/server/ItemStack.java
+++ b/src/main/java/net/minecraft/server/ItemStack.java
2020-06-25 14:04:34 +02:00
@@ -154,7 +154,7 @@ public final class ItemStack {
2018-07-17 22:32:05 +02:00
}
public boolean isEmpty() {
2020-06-25 14:04:34 +02:00
- return this == ItemStack.b ? true : (this.getItem() != null && this.getItem() != Items.AIR ? this.count <= 0 : true);
+ return this == ItemStack.NULL_ITEM || this.item == null || this.item == Items.AIR || this.count <= 0; // Paper
2018-07-17 22:32:05 +02:00
}
public ItemStack cloneAndSubtract(int i) {