2021-02-23 22:06:12 +01:00
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Shane Freeder <theboyetronic@gmail.com>
Date: Thu, 18 Feb 2021 20:23:28 +0000
Subject: [PATCH] misc debugging dumps
diff --git a/src/main/java/io/papermc/paper/util/TraceUtil.java b/src/main/java/io/papermc/paper/util/TraceUtil.java
new file mode 100644
2021-02-24 19:45:21 +01:00
index 0000000000000000000000000000000000000000..2d5494d2813b773e60ddba6790b750a9a08f21f8
2021-02-23 22:06:12 +01:00
--- /dev/null
+++ b/src/main/java/io/papermc/paper/util/TraceUtil.java
2021-02-24 19:45:21 +01:00
@@ -0,0 +1,18 @@
2021-02-23 22:06:12 +01:00
+package io.papermc.paper.util;
+
+import org.bukkit.Bukkit;
+
+public final class TraceUtil {
+
+ public static void dumpTraceForThread(Thread thread, String reason) {
+ Bukkit.getLogger().warning(thread.getName() + ": " + reason);
+ StackTraceElement[] trace = thread.getStackTrace();
+ for (StackTraceElement traceElement : trace) {
+ Bukkit.getLogger().warning("\tat " + traceElement);
+ }
+ }
2021-02-24 19:45:21 +01:00
+
+ public static void dumpTraceForThread(String reason) {
+ new Throwable(reason).printStackTrace();
+ }
2021-02-23 22:06:12 +01:00
+}
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
2021-03-09 00:12:31 +01:00
index b29705cb25423e2017f5b38cfa7affa738e0e592..c572ef2830f2653e2b30622bbac0a3b072bacd7a 100644
2021-02-23 22:06:12 +01:00
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
2021-03-09 00:12:31 +01:00
@@ -13,6 +13,7 @@ import io.netty.buffer.ByteBuf;
2021-02-23 22:06:12 +01:00
import io.netty.buffer.ByteBufOutputStream;
import io.netty.buffer.Unpooled;
import io.papermc.paper.event.entity.EntityMoveEvent;
+import io.papermc.paper.util.TraceUtil;
import it.unimi.dsi.fastutil.longs.LongIterator;
import java.awt.image.BufferedImage;
import java.io.BufferedWriter;
2021-03-09 00:12:31 +01:00
@@ -733,6 +734,7 @@ public abstract class MinecraftServer extends IAsyncTaskHandlerReentrant<TickTas
2021-02-23 22:06:12 +01:00
// CraftBukkit start
private boolean hasStopped = false;
public volatile boolean hasFullyShutdown = false; // Paper
+ private boolean hasLoggedStop = false; // Paper
private final Object stopLock = new Object();
public final boolean hasStopped() {
synchronized (stopLock) {
2021-03-09 00:12:31 +01:00
@@ -747,6 +749,7 @@ public abstract class MinecraftServer extends IAsyncTaskHandlerReentrant<TickTas
2021-02-23 22:06:12 +01:00
if (hasStopped) return;
hasStopped = true;
}
2021-02-24 19:45:21 +01:00
+ if (!hasLoggedStop && isDebugging()) TraceUtil.dumpTraceForThread("Server stopped"); // Paper
2021-02-23 22:06:12 +01:00
// Paper start - kill main thread, and kill it hard
shutdownThread = Thread.currentThread();
org.spigotmc.WatchdogThread.doStop(); // Paper
2021-03-09 00:12:31 +01:00
@@ -863,6 +866,8 @@ public abstract class MinecraftServer extends IAsyncTaskHandlerReentrant<TickTas
2021-02-23 22:06:12 +01:00
public void safeShutdown(boolean flag, boolean isRestarting) {
this.isRunning = false;
this.isRestarting = isRestarting;
+ this.hasLoggedStop = true; // Paper
2021-02-24 19:45:21 +01:00
+ if (isDebugging()) TraceUtil.dumpTraceForThread("Server stopped"); // Paper
2021-02-23 22:06:12 +01:00
if (flag) {
try {
this.serverThread.join();
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
2021-03-09 00:12:31 +01:00
index db0f0550ea011ff8222473de9940e4bfdc7b9e06..f84d879ef982ee4adcaa43e7c3db1f1003961983 100644
2021-02-23 22:06:12 +01:00
--- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java
+++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java
@@ -18,6 +18,7 @@ import com.mojang.serialization.Lifecycle;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufOutputStream;
import io.netty.buffer.Unpooled;
+import io.papermc.paper.util.TraceUtil;
import it.unimi.dsi.fastutil.objects.Object2ObjectLinkedOpenHashMap;
import java.awt.image.BufferedImage;
import java.io.File;
2021-02-23 22:11:50 +01:00
@@ -941,6 +942,7 @@ public final class CraftServer implements Server {
2021-02-23 22:06:12 +01:00
plugin.getDescription().getName(),
"This plugin is not properly shutting down its async tasks when it is being reloaded. This may cause conflicts with the newly loaded version of the plugin"
));
+ if (console.isDebugging()) TraceUtil.dumpTraceForThread(worker.getThread(), "still running"); // Paper
}
loadPlugins();
enablePlugins(PluginLoadOrder.STARTUP);