Paper/Spigot-Server-Patches/0060-Add-exception-reporting-event.patch

378 lines
18 KiB
Diff
Raw Normal View History

2018-01-11 06:31:19 +01:00
From 0674a65232371da02c375661f83d214aa59e4581 Mon Sep 17 00:00:00 2001
2016-02-29 02:15:51 +01:00
From: Joseph Hirschfeld <joe@ibj.io>
2016-03-01 00:09:49 +01:00
Date: Thu, 3 Mar 2016 03:15:41 -0600
2016-02-29 02:15:51 +01:00
Subject: [PATCH] Add exception reporting event
2016-03-01 00:09:49 +01:00
diff --git a/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java b/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java
new file mode 100644
index 00000000..93397188
2016-03-01 00:09:49 +01:00
--- /dev/null
+++ b/src/main/java/com/destroystokyo/paper/ServerSchedulerReportingWrapper.java
@@ -0,0 +1,38 @@
+package com.destroystokyo.paper;
+
+import com.google.common.base.Preconditions;
+import org.bukkit.craftbukkit.scheduler.CraftTask;
+import com.destroystokyo.paper.event.server.ServerExceptionEvent;
+import com.destroystokyo.paper.exception.ServerSchedulerException;
+
+/**
+ * Reporting wrapper to catch exceptions not natively
+ */
+public class ServerSchedulerReportingWrapper implements Runnable {
+
+ private final CraftTask internalTask;
+
+ public ServerSchedulerReportingWrapper(CraftTask internalTask) {
+ this.internalTask = Preconditions.checkNotNull(internalTask, "internalTask");
+ }
+
+ @Override
+ public void run() {
+ try {
+ internalTask.run();
+ } catch (RuntimeException e) {
+ internalTask.getOwner().getServer().getPluginManager().callEvent(
+ new ServerExceptionEvent(new ServerSchedulerException(e, internalTask))
+ );
+ throw e;
+ } catch (Throwable t) {
+ internalTask.getOwner().getServer().getPluginManager().callEvent(
+ new ServerExceptionEvent(new ServerSchedulerException(t, internalTask))
+ ); //Do not rethrow, since it is not permitted with Runnable#run
+ }
+ }
+
+ public CraftTask getInternalTask() {
+ return internalTask;
+ }
+}
\ No newline at end of file
2016-02-29 02:15:51 +01:00
diff --git a/src/main/java/net/minecraft/server/Chunk.java b/src/main/java/net/minecraft/server/Chunk.java
index 2a1c11a0..cc4a9dbe 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/Chunk.java
+++ b/src/main/java/net/minecraft/server/Chunk.java
2016-03-01 00:09:49 +01:00
@@ -1,5 +1,6 @@
package net.minecraft.server;
+import com.destroystokyo.paper.exception.ServerInternalException;
import com.google.common.base.Predicate;
import com.google.common.collect.Maps;
import com.google.common.collect.Queues;
@@ -16,6 +17,7 @@ import org.apache.logging.log4j.Logger;
2016-02-29 02:15:51 +01:00
import com.google.common.collect.Lists; // CraftBukkit
2016-06-23 04:18:41 +02:00
import org.bukkit.Server; // CraftBukkit
+import org.bukkit.craftbukkit.util.CraftMagicNumbers; // Paper
2016-02-29 02:15:51 +01:00
public class Chunk {
@@ -758,10 +760,15 @@ public class Chunk {
2016-02-29 02:15:51 +01:00
this.tileEntities.remove(blockposition);
2016-03-01 00:09:49 +01:00
// Paper end
2016-02-29 02:15:51 +01:00
} else {
- System.out.println("Attempted to place a tile entity (" + tileentity + ") at " + tileentity.position.getX() + "," + tileentity.position.getY() + "," + tileentity.position.getZ()
2016-03-01 00:09:49 +01:00
- + " (" + org.bukkit.craftbukkit.util.CraftMagicNumbers.getMaterial(getBlockData(blockposition).getBlock()) + ") where there was no entity tile!");
2016-02-29 02:15:51 +01:00
- System.out.println("Chunk coordinates: " + (this.locX * 16) + "," + (this.locZ * 16));
- new Exception().printStackTrace();
+ // Paper start
+ ServerInternalException e = new ServerInternalException(
+ "Attempted to place a tile entity (" + tileentity + ") at " + tileentity.position.getX() + ","
2016-03-01 00:09:49 +01:00
+ + tileentity.position.getY() + "," + tileentity.position.getZ()
+ + " (" + CraftMagicNumbers.getMaterial(getBlockData(blockposition).getBlock()) + ") where there was no entity tile!\n" +
+ "Chunk coordinates: " + (this.locX * 16) + "," + (this.locZ * 16));
2016-02-29 02:15:51 +01:00
+ e.printStackTrace();
+ ServerInternalException.reportInternalException(e);
+ // Paper end
// CraftBukkit end
}
}
diff --git a/src/main/java/net/minecraft/server/ChunkProviderServer.java b/src/main/java/net/minecraft/server/ChunkProviderServer.java
index e9bc23a6..4e51585a 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/ChunkProviderServer.java
+++ b/src/main/java/net/minecraft/server/ChunkProviderServer.java
2016-11-17 03:23:38 +01:00
@@ -12,6 +12,7 @@ import java.util.Iterator;
2016-03-01 00:09:49 +01:00
import java.util.List;
2016-05-12 04:07:46 +02:00
import java.util.Set;
import javax.annotation.Nullable;
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.exception.ServerInternalException;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
2016-02-29 02:15:51 +01:00
2016-11-17 03:23:38 +01:00
@@ -189,7 +190,11 @@ public class ChunkProviderServer implements IChunkProvider {
2016-02-29 02:15:51 +01:00
2016-03-01 00:09:49 +01:00
return chunk;
} catch (Exception exception) {
- ChunkProviderServer.a.error("Couldn\'t load chunk", exception);
2016-02-29 02:15:51 +01:00
+ // Paper start
2016-03-01 00:09:49 +01:00
+ String msg = "Couldn\'t load chunk";
+ ChunkProviderServer.a.error(msg, exception);
+ ServerInternalException.reportInternalException(exception);
+ // Paper end
return null;
}
}
2016-11-17 03:23:38 +01:00
@@ -198,7 +203,11 @@ public class ChunkProviderServer implements IChunkProvider {
2017-08-12 23:32:01 +02:00
try {
// this.chunkLoader.b(this.world, chunk); // Spigot
2016-03-01 00:09:49 +01:00
} catch (Exception exception) {
- ChunkProviderServer.a.error("Couldn\'t save entities", exception);
+ // Paper start
+ String msg = "Couldn\'t save entities";
+ ChunkProviderServer.a.error(msg, exception);
+ ServerInternalException.reportInternalException(exception);
2016-02-29 02:15:51 +01:00
+ // Paper end
}
2016-03-01 00:09:49 +01:00
}
2016-11-17 03:23:38 +01:00
@@ -208,9 +217,14 @@ public class ChunkProviderServer implements IChunkProvider {
2016-03-01 00:09:49 +01:00
chunk.setLastSaved(this.world.getTime());
this.chunkLoader.saveChunk(this.world, chunk, unloaded); // Spigot
2016-03-01 00:09:49 +01:00
} catch (IOException ioexception) {
- ChunkProviderServer.a.error("Couldn\'t save chunk", ioexception);
+ // Paper start
+ String msg = "Couldn\'t save chunk";
+ ChunkProviderServer.a.error(msg, ioexception);
+ ServerInternalException.reportInternalException(ioexception);
} catch (ExceptionWorldConflict exceptionworldconflict) {
- ChunkProviderServer.a.error("Couldn\'t save chunk; already in use by another instance of Minecraft?", exceptionworldconflict);
+ String msg = "Couldn\'t save chunk; already in use by another instance of Minecraft?";
+ ChunkProviderServer.a.error(msg, exceptionworldconflict);
+ ServerInternalException.reportInternalException(exceptionworldconflict);
2016-02-29 02:15:51 +01:00
}
2016-03-01 00:09:49 +01:00
}
2016-02-29 02:15:51 +01:00
diff --git a/src/main/java/net/minecraft/server/NameReferencingFileConverter.java b/src/main/java/net/minecraft/server/NameReferencingFileConverter.java
index 83322b85..b943a9b2 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/NameReferencingFileConverter.java
+++ b/src/main/java/net/minecraft/server/NameReferencingFileConverter.java
2017-05-14 20:05:01 +02:00
@@ -1,5 +1,7 @@
2016-03-01 00:09:49 +01:00
package net.minecraft.server;
2016-02-29 02:15:51 +01:00
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2017-05-14 20:05:01 +02:00
+import com.google.common.base.Charsets;
2016-03-01 00:09:49 +01:00
import com.google.common.base.Predicate;
import com.google.common.collect.Iterators;
2017-05-14 20:05:01 +02:00
import com.google.common.collect.Lists;
@@ -361,6 +363,7 @@ public class NameReferencingFileConverter {
2016-02-29 02:15:51 +01:00
root = NBTCompressedStreamTools.a(new java.io.FileInputStream(file1));
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
}
if (root != null) {
2017-05-14 20:05:01 +02:00
@@ -374,6 +377,7 @@ public class NameReferencingFileConverter {
2016-02-29 02:15:51 +01:00
NBTCompressedStreamTools.a(root, new java.io.FileOutputStream(file2));
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
}
2016-03-01 00:09:49 +01:00
}
2016-02-29 02:15:51 +01:00
// CraftBukkit end
diff --git a/src/main/java/net/minecraft/server/PersistentCollection.java b/src/main/java/net/minecraft/server/PersistentCollection.java
index 936d6c64..50056f49 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/PersistentCollection.java
+++ b/src/main/java/net/minecraft/server/PersistentCollection.java
2016-03-01 00:09:49 +01:00
@@ -1,5 +1,6 @@
package net.minecraft.server;
2016-02-29 02:15:51 +01:00
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 02:15:51 +01:00
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import java.io.DataInputStream;
2016-05-12 04:07:46 +02:00
@@ -53,6 +54,7 @@ public class PersistentCollection {
2016-03-01 00:09:49 +01:00
}
} catch (Exception exception1) {
exception1.printStackTrace();
+ ServerInternalException.reportInternalException(exception1); // Paper
2016-02-29 02:15:51 +01:00
}
}
2016-05-12 04:07:46 +02:00
@@ -102,6 +104,7 @@ public class PersistentCollection {
2016-02-29 02:15:51 +01:00
}
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
}
2016-03-01 00:09:49 +01:00
}
2016-02-29 02:15:51 +01:00
diff --git a/src/main/java/net/minecraft/server/RegionFile.java b/src/main/java/net/minecraft/server/RegionFile.java
index 1ba26de5..6a92b5af 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/RegionFile.java
+++ b/src/main/java/net/minecraft/server/RegionFile.java
2016-03-01 00:09:49 +01:00
@@ -1,5 +1,6 @@
2016-02-29 02:15:51 +01:00
package net.minecraft.server;
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 02:15:51 +01:00
import com.google.common.collect.Lists;
import java.io.BufferedInputStream;
2016-03-01 00:09:49 +01:00
import java.io.BufferedOutputStream;
2016-11-17 03:23:38 +01:00
@@ -82,6 +83,7 @@ public class RegionFile {
2016-02-29 02:15:51 +01:00
}
} catch (IOException ioexception) {
ioexception.printStackTrace();
+ ServerInternalException.reportInternalException(ioexception); // Paper
}
}
2017-04-29 02:25:52 +02:00
@@ -209,6 +211,7 @@ public class RegionFile {
2016-11-17 03:23:38 +01:00
this.b(i, j, (int) (MinecraftServer.aw() / 1000L));
2016-02-29 02:15:51 +01:00
} catch (IOException ioexception) {
ioexception.printStackTrace();
+ ServerInternalException.reportInternalException(ioexception); // Paper
}
}
diff --git a/src/main/java/net/minecraft/server/RegionFileCache.java b/src/main/java/net/minecraft/server/RegionFileCache.java
index c15a0d1f..5f9e9dde 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/RegionFileCache.java
+++ b/src/main/java/net/minecraft/server/RegionFileCache.java
2016-03-01 00:09:49 +01:00
@@ -1,5 +1,6 @@
2016-02-29 02:15:51 +01:00
package net.minecraft.server;
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 02:15:51 +01:00
import com.google.common.collect.Maps;
import java.io.DataInputStream;
import java.io.DataOutputStream;
@@ -68,6 +69,7 @@ public class RegionFileCache {
2016-02-29 02:15:51 +01:00
}
} catch (IOException ioexception) {
ioexception.printStackTrace();
+ ServerInternalException.reportInternalException(ioexception); // Paper
}
}
diff --git a/src/main/java/net/minecraft/server/SpawnerCreature.java b/src/main/java/net/minecraft/server/SpawnerCreature.java
index 1c7c187c..68a04532 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/SpawnerCreature.java
+++ b/src/main/java/net/minecraft/server/SpawnerCreature.java
2016-07-16 00:36:53 +02:00
@@ -7,6 +7,7 @@ import java.util.Random;
import java.util.Set;
2016-03-01 00:09:49 +01:00
// CraftBukkit start
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 02:15:51 +01:00
import org.bukkit.craftbukkit.util.LongHash;
import org.bukkit.craftbukkit.util.LongHashSet;
import org.bukkit.event.entity.CreatureSpawnEvent.SpawnReason;
2016-11-17 03:23:38 +01:00
@@ -177,6 +178,7 @@ public final class SpawnerCreature {
2016-02-29 02:15:51 +01:00
entityinsentient = (EntityInsentient) biomebase_biomemeta.b.getConstructor(new Class[] { World.class}).newInstance(new Object[] { worldserver});
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
return j1;
}
2017-04-11 05:11:26 +02:00
@@ -288,6 +290,7 @@ public final class SpawnerCreature {
2016-02-29 02:15:51 +01:00
entityinsentient = (EntityInsentient) biomebase_biomemeta.b.getConstructor(new Class[] { World.class}).newInstance(new Object[] { world});
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
continue;
}
diff --git a/src/main/java/net/minecraft/server/VillageSiege.java b/src/main/java/net/minecraft/server/VillageSiege.java
index 9ff4f23a..6fce3015 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/VillageSiege.java
+++ b/src/main/java/net/minecraft/server/VillageSiege.java
@@ -1,5 +1,7 @@
package net.minecraft.server;
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.exception.ServerInternalException;
2016-02-29 02:15:51 +01:00
+
import java.util.Iterator;
import java.util.List;
2016-05-12 04:07:46 +02:00
import javax.annotation.Nullable;
2016-11-17 03:23:38 +01:00
@@ -136,6 +138,7 @@ public class VillageSiege {
entityzombie.prepare(this.a.D(new BlockPosition(entityzombie)), (GroupDataEntity) null);
2016-02-29 02:15:51 +01:00
} catch (Exception exception) {
exception.printStackTrace();
+ ServerInternalException.reportInternalException(exception); // Paper
return false;
}
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
index 89197281..6be9c181 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
2016-03-01 00:09:49 +01:00
@@ -1,5 +1,7 @@
package net.minecraft.server;
+import com.destroystokyo.paper.event.server.ServerExceptionEvent;
+import com.destroystokyo.paper.exception.ServerInternalException;
import com.google.common.base.Function;
2017-05-14 20:05:01 +02:00
import com.google.common.base.MoreObjects;
2016-03-01 00:09:49 +01:00
import com.google.common.base.Predicate;
2017-12-09 18:37:09 +01:00
@@ -1457,8 +1459,10 @@ public abstract class World implements IBlockAccess {
2016-02-29 02:15:51 +01:00
} catch (Throwable throwable1) {
entity.tickTimer.stopTiming();
2016-03-25 05:59:37 +01:00
// Paper start - Prevent tile entity and entity crashes
2016-02-29 02:15:51 +01:00
- System.err.println("Entity threw exception at " + entity.world.getWorld().getName() + ":" + entity.locX + "," + entity.locY + "," + entity.locZ);
+ String msg = "Entity threw exception at " + entity.world.getWorld().getName() + ":" + entity.locX + "," + entity.locY + "," + entity.locZ;
+ System.err.println(msg);
throwable1.printStackTrace();
+ getServer().getPluginManager().callEvent(new ServerExceptionEvent(new ServerInternalException(msg, throwable1)));
entity.dead = true;
continue;
2016-03-01 00:09:49 +01:00
// Paper end
2017-12-09 18:37:09 +01:00
@@ -1523,8 +1527,10 @@ public abstract class World implements IBlockAccess {
2016-03-25 05:59:37 +01:00
this.methodProfiler.b();
2016-02-29 02:15:51 +01:00
} catch (Throwable throwable2) {
2016-03-01 00:09:49 +01:00
// Paper start - Prevent tile entity and entity crashes
2016-02-29 02:15:51 +01:00
- System.err.println("TileEntity threw exception at " + tileentity.world.getWorld().getName() + ":" + tileentity.position.getX() + "," + tileentity.position.getY() + "," + tileentity.position.getZ());
+ String msg = "TileEntity threw exception at " + tileentity.world.getWorld().getName() + ":" + tileentity.position.getX() + "," + tileentity.position.getY() + "," + tileentity.position.getZ();
+ System.err.println(msg);
throwable2.printStackTrace();
+ getServer().getPluginManager().callEvent(new ServerExceptionEvent(new ServerInternalException(msg, throwable2)));
tilesThisCycle--;
2016-03-01 00:09:49 +01:00
this.tileEntityListTick.remove(tileTickPosition--);
2016-02-29 02:15:51 +01:00
continue;
diff --git a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
index d50bbd2a..bce41128 100644
2016-02-29 02:15:51 +01:00
--- a/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
+++ b/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
@@ -15,6 +15,9 @@ import java.util.concurrent.atomic.AtomicReference;
2016-03-01 00:09:49 +01:00
import java.util.logging.Level;
2016-02-29 02:15:51 +01:00
import co.aikar.timings.MinecraftTimings; // Paper
2016-03-01 00:09:49 +01:00
+import com.destroystokyo.paper.ServerSchedulerReportingWrapper;
+import com.destroystokyo.paper.event.server.ServerExceptionEvent;
+import com.destroystokyo.paper.exception.ServerSchedulerException;
import org.apache.commons.lang.Validate;
import org.bukkit.plugin.IllegalPluginAccessException;
import org.bukkit.plugin.Plugin;
@@ -352,18 +355,24 @@ public class CraftScheduler implements BukkitScheduler {
2016-02-29 02:15:51 +01:00
try {
task.run();
} catch (final Throwable throwable) {
+ // Paper start
+ String msg = String.format(
+ "Task #%s for %s generated an exception",
+ task.getTaskId(),
+ task.getOwner().getDescription().getFullName());
task.getOwner().getLogger().log(
Level.WARNING,
- String.format(
- "Task #%s for %s generated an exception",
- task.getTaskId(),
- task.getOwner().getDescription().getFullName()),
+ msg,
throwable);
+ task.getOwner().getServer().getPluginManager().callEvent(
+ new ServerExceptionEvent(new ServerSchedulerException(msg, throwable, task))
+ );
+ // Paper end
}
parsePending();
} else {
debugTail = debugTail.setNext(new CraftAsyncDebugger(currentTick + RECENT_TICKS, task.getOwner(), task.getTaskClass()));
- executor.execute(task);
+ executor.execute(new ServerSchedulerReportingWrapper(task)); // Paper
// We don't need to parse pending
// (async tasks must live with race-conditions if they attempt to cancel between these few lines of code)
}
--
2018-01-11 06:31:19 +01:00
2.14.3
2016-02-29 02:15:51 +01:00