Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-11-05 02:10:30 +01:00
Code Issues Projects Releases Wiki Activity
faf59c3242
Paper/Spigot-Server-Patches/0136-Chunk-registration-fixes.patch

26 lines
1.0 KiB
Diff
Raw Normal View History

Numerous fixes to entity related changes While it wasn't really "broken" before, if plugins use NMS (which they really should't be) and mess with entity management themselves, and get it wrong, they could ultimately corrupt our state expectations. I've been unable to reproduce any issues locally, but these changes are the result of me analyzing the code pretty deeply and seeing about how to make it more durable to abnormal usage. Any servers seeing oddities, please run with -Ddebug.entities=true and send me any logs triggered.
2019-04-06 05:08:45 +02:00
From fbb663799bcceee4cfcafbac14a6b78fb196a209 Mon Sep 17 00:00:00 2001
add a chunk registration fix World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated Keep them consistent
2016-09-22 04:56:19 +02:00
From: Aikar <aikar@aikar.co>
Date: Wed, 21 Sep 2016 22:54:28 -0400
Subject: [PATCH] Chunk registration fixes
World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated
Keep them consistent
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
Numerous fixes to entity related changes While it wasn't really "broken" before, if plugins use NMS (which they really should't be) and mess with entity management themselves, and get it wrong, they could ultimately corrupt our state expectations. I've been unable to reproduce any issues locally, but these changes are the result of me analyzing the code pretty deeply and seeing about how to make it more durable to abnormal usage. Any servers seeing oddities, please run with -Ddebug.entities=true and send me any logs triggered.
2019-04-06 05:08:45 +02:00
index 336e6aeef6..282d6ae84c 100644
add a chunk registration fix World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated Keep them consistent
2016-09-22 04:56:19 +02:00
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
Numerous fixes to entity related changes While it wasn't really "broken" before, if plugins use NMS (which they really should't be) and mess with entity management themselves, and get it wrong, they could ultimately corrupt our state expectations. I've been unable to reproduce any issues locally, but these changes are the result of me analyzing the code pretty deeply and seeing about how to make it more durable to abnormal usage. Any servers seeing oddities, please run with -Ddebug.entities=true and send me any logs triggered.
2019-04-06 05:08:45 +02:00
@@ -1473,7 +1473,7 @@ public abstract class World implements IEntityAccess, GeneratorAccess, IIBlockAc
Update Paper to MC 1.12-pre5
2017-05-21 06:41:39 +02:00
}
add a chunk registration fix World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated Keep them consistent
2016-09-22 04:56:19 +02:00
Update to 1.12-pre6
2017-05-31 10:04:52 +02:00
i = MathHelper.floor(entity.locX / 16.0D);
- j = MathHelper.floor(entity.locY / 16.0D);
+ j = Math.min(15, Math.max(0, MathHelper.floor(entity.locY / 16.0D))); // Paper - stay consistent with chunk add/remove behavior
Update Paper to MC 1.12-pre5
2017-05-21 06:41:39 +02:00
int k = MathHelper.floor(entity.locZ / 16.0D);
add a chunk registration fix World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated Keep them consistent
2016-09-22 04:56:19 +02:00
Updated Upstream (Bukkit/CraftBukkit/Spigot) Developers!: You will need to clean up your work/Minecraft/1.13.2 folder for this Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: b850a822 SPIGOT-4526: Add conversion time API for Zombie & subclasses CraftBukkit Changes: 38cf676e SPIGOT-4534: CreatureSpawnEvent not being called for CHUNK_GEN b446cb5d SPIGOT-4527: Fix sponges with waterlogged blocks 6ec8ea5c SPIGOT-4526: Add conversion time API for Zombie & subclasses c64fe508 Mappings Update a3c2ec03 Fix missing ServerListPingEvent call for legacy pings Spigot Changes: 1dc156ce Rebuild patches 140f654d Mappings Update
2018-12-17 06:18:06 +01:00
if (!entity.inChunk || entity.chunkX != i || entity.chunkY != j || entity.chunkZ != k) {
add a chunk registration fix World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated Keep them consistent
2016-09-22 04:56:19 +02:00
--
Numerous fixes to entity related changes While it wasn't really "broken" before, if plugins use NMS (which they really should't be) and mess with entity management themselves, and get it wrong, they could ultimately corrupt our state expectations. I've been unable to reproduce any issues locally, but these changes are the result of me analyzing the code pretty deeply and seeing about how to make it more durable to abnormal usage. Any servers seeing oddities, please run with -Ddebug.entities=true and send me any logs triggered.
2019-04-06 05:08:45 +02:00
2.21.0
add a chunk registration fix World checks and the Chunk Add logic are inconsistent on how Y > 256, < 0, is treated Keep them consistent
2016-09-22 04:56:19 +02:00
Reference in New Issue Copy Permalink