Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-01-10 02:07:37 +01:00
Code Issues Projects Releases Wiki Activity

SPIGOT-6714: Don't fire PlayerBucketEvent when empty

Browse Source 
By: Noah van der Aa <ndvdaa@gmail.com>
This commit is contained in:
CraftBukkit/Spigot 2021-08-18 17:06:40 +10:00
parent 3a23c54a91
commit 03aecfb428
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
paper-server/nms-patches/net/minecraft/world/item/ItemBucket.patch
View File

@ -23,6 +23,7 @@
IFluidSource ifluidsource = (IFluidSource) iblockdata.getBlock(); IFluidSource ifluidsource = (IFluidSource) iblockdata.getBlock();
+ // CraftBukkit start + // CraftBukkit start
+ ItemStack dummyFluid = ifluidsource.removeFluid(DummyGeneratorAccess.INSTANCE, blockposition, iblockdata); + ItemStack dummyFluid = ifluidsource.removeFluid(DummyGeneratorAccess.INSTANCE, blockposition, iblockdata);
+ if (dummyFluid.isEmpty()) return InteractionResultWrapper.fail(itemstack); // Don't fire event if the bucket won't be filled.
+ PlayerBucketFillEvent event = CraftEventFactory.callPlayerBucketFillEvent((WorldServer) world, entityhuman, blockposition, blockposition, movingobjectpositionblock.getDirection(), itemstack, dummyFluid.getItem()); + PlayerBucketFillEvent event = CraftEventFactory.callPlayerBucketFillEvent((WorldServer) world, entityhuman, blockposition, blockposition, movingobjectpositionblock.getDirection(), itemstack, dummyFluid.getItem());
+ +
+ if (event.isCancelled()) { + if (event.isCancelled()) {