Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-03-19 10:09:39 +01:00
Code Issues Projects Releases Wiki Activity

Added negative id check to Material.getMaterial(int). Fixes BUKKIT-3414

Browse Source 
Negative id values would try to access the array out of bounds and throw an java.lang.ArrayIndexOutOfBoundsException.

By: MikeMatrix <m.braun92@gmail.com>
This commit is contained in:
Bukkit/Spigot 2013-01-11 02:07:38 +01:00
parent de7c26870b
commit 08fa8ed053
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
paper-api/src/main/java/org/bukkit/Material.java
View File

@ -528,7 +528,7 @@ public enum Material {
* @return Material if found, or null
*/
public static Material getMaterial(final int id) {
if (byId.length > id) {
if (byId.length > id && id >= 0) {
return byId[id];
} else {
return null;

1
paper-api/src/test/java/org/bukkit/MaterialTest.java
View File

@ -33,6 +33,7 @@ public class MaterialTest {
@Test
public void getByOutOfRangeId() {
assertThat(Material.getMaterial(Integer.MAX_VALUE), is(nullValue()));
assertThat(Material.getMaterial(Integer.MIN_VALUE), is(nullValue()));
}
@Test