mirror of
https://github.com/PaperMC/Paper.git
synced 2025-03-02 11:22:01 +01:00
Added negative id check to Material.getMaterial(int). Fixes BUKKIT-3414
Negative id values would try to access the array out of bounds and throw an java.lang.ArrayIndexOutOfBoundsException. By: MikeMatrix <m.braun92@gmail.com>
This commit is contained in:
parent
de7c26870b
commit
08fa8ed053
@ -528,7 +528,7 @@ public enum Material {
|
||||
* @return Material if found, or null
|
||||
*/
|
||||
public static Material getMaterial(final int id) {
|
||||
if (byId.length > id) {
|
||||
if (byId.length > id && id >= 0) {
|
||||
return byId[id];
|
||||
} else {
|
||||
return null;
|
||||
|
@ -33,6 +33,7 @@ public class MaterialTest {
|
||||
@Test
|
||||
public void getByOutOfRangeId() {
|
||||
assertThat(Material.getMaterial(Integer.MAX_VALUE), is(nullValue()));
|
||||
assertThat(Material.getMaterial(Integer.MIN_VALUE), is(nullValue()));
|
||||
}
|
||||
|
||||
@Test
|
||||
|
Loading…
Reference in New Issue
Block a user