From 1dbe87c8cc2259860a28bdb2f8ddd834692ea29b Mon Sep 17 00:00:00 2001 From: md_5 Date: Tue, 5 Mar 2019 16:59:40 +1100 Subject: [PATCH] SPIGOT-4646: Test + fix InventoryWrapper.getContents --- .../inventory/InventoryWrapper.java | 2 +- .../inventory/InventoryWrapperTest.java | 23 +++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 src/test/java/org/bukkit/craftbukkit/inventory/InventoryWrapperTest.java diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/InventoryWrapper.java b/src/main/java/org/bukkit/craftbukkit/inventory/InventoryWrapper.java index 9c5ec924eb..c280dbbc82 100644 --- a/src/main/java/org/bukkit/craftbukkit/inventory/InventoryWrapper.java +++ b/src/main/java/org/bukkit/craftbukkit/inventory/InventoryWrapper.java @@ -128,7 +128,7 @@ public class InventoryWrapper implements IInventory { List items = new ArrayList(size); for (int i = 0; i < size; i++) { - items.set(i, getItem(i)); + items.add(getItem(i)); } return items; diff --git a/src/test/java/org/bukkit/craftbukkit/inventory/InventoryWrapperTest.java b/src/test/java/org/bukkit/craftbukkit/inventory/InventoryWrapperTest.java new file mode 100644 index 0000000000..9448c18826 --- /dev/null +++ b/src/test/java/org/bukkit/craftbukkit/inventory/InventoryWrapperTest.java @@ -0,0 +1,23 @@ +package org.bukkit.craftbukkit.inventory; + +import junit.framework.Assert; +import org.bukkit.Material; +import org.bukkit.inventory.Inventory; +import org.bukkit.inventory.ItemStack; +import org.junit.Test; + +public class InventoryWrapperTest { + + @Test + public void test() { + Inventory raw = new CraftInventoryCustom(null, 9); + raw.addItem(new ItemStack(Material.STONE)); + + Assert.assertTrue(raw.contains(Material.STONE)); + + InventoryWrapper wrapper = new InventoryWrapper(raw); + CraftInventory proxy = new CraftInventory(wrapper); + + Assert.assertTrue(proxy.contains(Material.STONE)); + } +}