Fix NPE in CraftBanner due to null world, potentially other things fixed

Banners only load color if the world is set. I don't know why...

For some reason, the world was not set on these, so it was changing behavior.

So if we want an accurate clone, world needs to be set.
This commit is contained in:
Aikar 2018-08-15 01:21:10 -04:00
parent 36e6c991af
commit 3bc40e491f
No known key found for this signature in database
GPG Key ID: 401ADFC9891FAAFE

View File

@ -0,0 +1,22 @@
From 15350e98eed7c1e36d8dd8da292355542963032b Mon Sep 17 00:00:00 2001
From: Aikar <aikar@aikar.co>
Date: Wed, 15 Aug 2018 01:19:04 -0400
Subject: [PATCH] Pass World to Tile Entity Snapshots
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftBlockEntityState.java b/src/main/java/org/bukkit/craftbukkit/block/CraftBlockEntityState.java
index d4d9c5fc50..a72bbdbedb 100644
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftBlockEntityState.java
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftBlockEntityState.java
@@ -50,7 +50,7 @@ public class CraftBlockEntityState<T extends TileEntity> extends CraftBlockState
if (DISABLE_SNAPSHOT) {
this.snapshot = this.tileEntity;
} else {
- this.snapshot = this.createSnapshot(this.tileEntity, null);
+ this.snapshot = this.createSnapshot(this.tileEntity, tileEntity.getWorld());
}
// copy tile entity data:
if(this.snapshot != null) {
--
2.18.0