Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-11-23 19:15:32 +01:00
Code Issues Projects Releases Wiki Activity

Improved the potion test to detect missing PotionType values.

Browse Source
This commit is contained in:
Wesley Wolfe 2012-11-01 03:38:25 -05:00
parent 87d25c4cc6
commit 3dd0580d50
1 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/test/java/org/bukkit/potion/PotionTest.java
View File

@ -1,6 +1,11 @@
package org.bukkit.potion; package org.bukkit.potion;
import static org.junit.Assert.*; import static org.junit.Assert.*;
import static org.hamcrest.Matchers.*;
import java.lang.reflect.Field;
import java.util.EnumMap;
import java.util.Map;
import org.bukkit.craftbukkit.potion.CraftPotionBrewer; import org.bukkit.craftbukkit.potion.CraftPotionBrewer;
import org.junit.BeforeClass; import org.junit.BeforeClass;
@ -9,6 +14,7 @@ import org.junit.Test;
import net.minecraft.server.MobEffectList; import net.minecraft.server.MobEffectList;
public class PotionTest { public class PotionTest {
@BeforeClass @BeforeClass
public static void setUp() { public static void setUp() {
Potion.setPotionBrewer(new CraftPotionBrewer()); Potion.setPotionBrewer(new CraftPotionBrewer());
@ -20,8 +26,32 @@ public class PotionTest {
public void getEffects() { public void getEffects() {
for (PotionType type : PotionType.values()) { for (PotionType type : PotionType.values()) {
for (PotionEffect effect : new Potion(type).getEffects()) { for (PotionEffect effect : new Potion(type).getEffects()) {
assertTrue(effect.getType() == PotionEffectType.getById(effect.getType().getId())); PotionEffectType potionType = effect.getType();
assertThat(effect.getType(), is(sameInstance(PotionEffectType.getById(potionType.getId()))));
assertNotNull(potionType.getName(), PotionType.getByEffect(potionType));
} }
} }
} }
@Test
public void testEffectCompleteness() throws SecurityException, IllegalAccessException, NoSuchFieldException {
Field durationsField = net.minecraft.server.PotionBrewer.class.getDeclaredField("effectDurations");
durationsField.setAccessible(true);
Map<Integer, ?> effectDurations = (Map<Integer, ?>) durationsField.get(null);
Map<PotionType, String> effects = new EnumMap(PotionType.class);
for (int id : effectDurations.keySet()) {
PotionEffectType type = PotionEffectType.getById(id);
assertNotNull(String.valueOf(id), PotionEffectType.getById(id));
PotionType enumType = PotionType.getByEffect(type);
assertNotNull(type.getName(), enumType);
assertThat(enumType.name(), effects.put(enumType, enumType.name()), is((String)null));
}
assertThat(effects.entrySet(), hasSize(effectDurations.size()));
assertThat(effectDurations.entrySet(), hasSize(PotionType.values().length - /* WATER */ 1));
}
} }