Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-11-24 03:25:15 +01:00
Code Issues Projects Releases Wiki Activity

Don't update physics until after the place event. Fixes BUKKIT-3316

Browse Source 
If you cancel a BlockPlaceEvent for a sign the world is updated as if
the block was placed and then destroyed. To avoid this we set the block
without updating physics then apply the update after the event.
This commit is contained in:
Wizjany 2012-12-27 13:55:32 -05:00 committed by Travis Watkins
parent 49da990ee3
commit 5963da294f
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/net/minecraft/server/ItemSign.java
View File

@ -48,17 +48,23 @@ public class ItemSign extends Item {
if (l == 1) { if (l == 1) {
int i1 = MathHelper.floor((double) ((entityhuman.yaw + 180.0F) * 16.0F / 360.0F) + 0.5D) & 15; int i1 = MathHelper.floor((double) ((entityhuman.yaw + 180.0F) * 16.0F / 360.0F) + 0.5D) & 15;
world.setTypeIdAndData(i, j, k, Block.SIGN_POST.id, i1); // CraftBukkit start - sign
world.setRawTypeIdAndData(i, j, k, Block.SIGN_POST.id, i1);
} else { } else {
world.setTypeIdAndData(i, j, k, Block.WALL_SIGN.id, l); world.setRawTypeIdAndData(i, j, k, Block.WALL_SIGN.id, l);
} }
// CraftBukkit start - sign
org.bukkit.event.block.BlockPlaceEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callBlockPlaceEvent(world, entityhuman, blockState, clickedX, clickedY, clickedZ); org.bukkit.event.block.BlockPlaceEvent event = org.bukkit.craftbukkit.event.CraftEventFactory.callBlockPlaceEvent(world, entityhuman, blockState, clickedX, clickedY, clickedZ);
if (event.isCancelled() || !event.canBuild()) { if (event.isCancelled() || !event.canBuild()) {
event.getBlockPlaced().setTypeIdAndData(blockState.getTypeId(), blockState.getRawData(), false); event.getBlockPlaced().setTypeIdAndData(blockState.getTypeId(), blockState.getRawData(), false);
return false; return false;
} else {
if (l == 1) {
world.update(i, j, k, Block.SIGN_POST.id);
} else {
world.update(i, j, k, Block.WALL_SIGN.id);
}
} }
// CraftBukkit end // CraftBukkit end