Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-12-29 12:27:59 +01:00
Code Issues Projects Releases Wiki Activity

Remove CraftScheduler Async Task Debugger

Browse Source 
I have not once ever seen this system help debug a crash.
One report of a suspected memory leak with the system.

This adds additional overhead to asynchronous task dispatching
This commit is contained in:
Aikar 2017-02-05 00:04:04 -05:00
parent d2f4d82ce2
commit 5a81bf12ef
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
paper-server/src/main/java/org/bukkit/craftbukkit/scheduler/CraftScheduler.java
View File

@ -432,7 +432,7 @@ public class CraftScheduler implements BukkitScheduler {
}
this.parsePending();
} else {
this.debugTail = this.debugTail.setNext(new CraftAsyncDebugger(this.currentTick + CraftScheduler.RECENT_TICKS, task.getOwner(), task.getTaskClass()));
// this.debugTail = this.debugTail.setNext(new CraftAsyncDebugger(this.currentTick + CraftScheduler.RECENT_TICKS, task.getOwner(), task.getTaskClass())); // Paper
this.executor.execute(new com.destroystokyo.paper.ServerSchedulerReportingWrapper(task)); // Paper
// We don't need to parse pending
// (async tasks must live with race-conditions if they attempt to cancel between these few lines of code)
@ -447,7 +447,7 @@ public class CraftScheduler implements BukkitScheduler {
}
this.pending.addAll(temp);
temp.clear();
this.debugHead = this.debugHead.getNextHead(this.currentTick);
//this.debugHead = this.debugHead.getNextHead(this.currentTick); // Paper
}
private void addTask(final CraftTask task) {
@ -505,10 +505,15 @@ public class CraftScheduler implements BukkitScheduler {
@Override
public String toString() {
// Paper start
return "";
/*
int debugTick = this.currentTick;
StringBuilder string = new StringBuilder("Recent tasks from ").append(debugTick - CraftScheduler.RECENT_TICKS).append('-').append(debugTick).append('{');
this.debugHead.debugTo(string);
return string.append('}').toString();
*/
// Paper end
}
@Deprecated