Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2025-03-02 11:22:01 +01:00
Code Issues Projects Releases Wiki Activity

Only fetch an online UUID in online mode

Browse Source 
The previous code would get an online UUID even in offline mode that
breaks plugins if the player joins.

Example: You want to store data for player "Test" who never joined. An
online UUID is created and you save it using that UUID.

The player Test joins with an offline UUID but that will not match the
online UUID of the saved data.

Adapted from Spigot commit 25b673fd7e418e21eb445a9e39d51baa0c0ab8b6

By: Maxim Van de Wynckel <maxim_vdw@hotmail.com>
This commit is contained in:
CraftBukkit/Spigot 2023-12-31 10:46:30 +11:00
parent b92cff8a2d
commit 5e82782283
1 changed files with 7 additions and 2 deletions

9
paper-server/src/main/java/org/bukkit/craftbukkit/CraftServer.java
View File

@ -1746,8 +1746,13 @@ public final class CraftServer implements Server {
OfflinePlayer result = getPlayerExact(name);
if (result == null) {
// This is potentially blocking :(
GameProfile profile = console.getProfileCache().get(name).orElse(null);
GameProfile profile = null;
// Only fetch an online UUID in online mode
if (getOnlineMode()) {
// This is potentially blocking :(
profile = console.getProfileCache().get(name).orElse(null);
}
if (profile == null) {
// Make an OfflinePlayer using an offline mode UUID since the name has no profile
result = getOfflinePlayer(new GameProfile(UUID.nameUUIDFromBytes(("OfflinePlayer:" + name).getBytes(Charsets.UTF_8)), name));