Upstream/Paper
1
0
Fork 0
mirror of https://github.com/PaperMC/Paper.git synced 2024-11-22 10:35:38 +01:00
Code Issues Projects Releases Wiki Activity

[ci skip] Update contributing guidelines to include identifying commit titles in comments (#10162)

Browse Source
This commit is contained in:
Nassim Jahnke 2024-01-14 00:42:59 +01:00 committed by GitHub
parent 17275ffd68
commit 78fcb8e766
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
CONTRIBUTING.md
View File

@ -206,27 +206,28 @@ when making and submitting changes.
All modifications to non-Paper files should be marked. All modifications to non-Paper files should be marked.
- Multi-line changes start with `// Paper start` and end with `// Paper end`; - You need to add a comment with a short and identifiable description of the patch:
- You can put a comment with an explanation if it isn't obvious, like this: `// Paper start - <COMMIT DESCRIPTION>`
`// Paper start - reason`. - The comments should generally be about the reason the change was made, what
- The comments should generally be about the reason the change was made, what it was before, or what the change is.
it was before, or what the change is. - After the general commit description, you can add additional information either
- Multi-line messages should start with `// Paper start` and use `/* Multi after a `;` or in the next line.
line message here */` for the message itself. - Multi-line changes start with `// Paper start - <COMMIT DESCRIPTION>` and end
- One-line changes should have `// Paper` or `// Paper - reason`. with `// Paper end - <COMMIT DESCRIPTION>`.
- One-line changes should have `// Paper - <COMMIT DESCRIPTION>` at the end of the line.
Here's an example of how to mark changes by Paper: Here's an example of how to mark changes by Paper:
```java ```java
entity.getWorld().dontbeStupid(); // Paper - was beStupid() which is bad entity.getWorld().dontBeStupid(); // Paper - Was beStupid(), which is bad
entity.getFriends().forEach(Entity::explode); entity.getFriends().forEach(Entity::explode);
entity.a(); entity.updateFriends();
entity.b();
// Paper start - use plugin-set spawn // Paper start - Use plugin-set spawn
// entity.getWorld().explode(entity.getWorld().getSpawn()); // entity.getWorld().explode(entity.getWorld().getSpawn());
Location spawnLocation = ((CraftWorld)entity.getWorld()).getSpawnLocation(); Location spawnLocation = ((CraftWorld)entity.getWorld()).getSpawnLocation();
entity.getWorld().explode(new BlockPosition(spawnLocation.getX(), spawnLocation.getY(), spawnLocation.getZ())); entity.getWorld().explode(new BlockPosition(spawnLocation.getX(), spawnLocation.getY(), spawnLocation.getZ()));
// Paper end // Paper end - Use plugin-set spawn
``` ```
We generally follow the usual Java style (aka. Oracle style), or what is programmed We generally follow the usual Java style (aka. Oracle style), or what is programmed