Added pull request conventions that should be followed if you want your pull request accepted.

This commit is contained in:
EvilSeph 2011-02-18 17:15:19 -05:00
parent 7fe0aa7460
commit 7b6713b918

View File

@ -13,13 +13,16 @@ We use maven to handle our dependencies.
* *Note*: this is not needed as the repository we use has Bukkit too, but you might have a newer one (with your own changes :D)
* Check out this repo and: `mvn clean package`
Coding Conventions
Coding and Pull Request Conventions
-----------
* We generally follow the Sun/Oracle coding standards.
* No tabs; use 4 spaces instead.
* No trailing whitespaces.
* No 80 column limit or 'weird' midstatement newlines.
* The number of commits in a pull request should be kept to a minimum (squish them into one most of the time - use common sense!).
* No merges should be included in pull requests unless the pull request's purpose is a merge.
* Pull requests should be tested (does it compile? AND does it work?) before submission.
If you make changes or add net.minecraft.server classes it is mandatory to: