Fix poor action helpers API name (#6518)

This commit is contained in:
Maddy Miller 2021-08-29 17:20:14 +10:00 committed by GitHub
parent 785bee00eb
commit ba1773373c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,11 +1,11 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Madeline Miller <mnmiller1@me.com> From: Madeline Miller <mnmiller1@me.com>
Date: Sun, 29 Aug 2021 16:22:46 +1000 Date: Sun, 29 Aug 2021 17:00:56 +1000
Subject: [PATCH] Add helpers for left/right hand to Action Subject: [PATCH] Add helpers for left/right hand to Action
diff --git a/src/main/java/org/bukkit/event/block/Action.java b/src/main/java/org/bukkit/event/block/Action.java diff --git a/src/main/java/org/bukkit/event/block/Action.java b/src/main/java/org/bukkit/event/block/Action.java
index 25d26e3fe713311e66d7e634a6c32af61f4cef59..839dd6765c7b3338d5fc55d6f336cf7f22bfa959 100644 index 25d26e3fe713311e66d7e634a6c32af61f4cef59..f0b672bbfcd0eb17f3953ffcd0e728f5b3ec909b 100644
--- a/src/main/java/org/bukkit/event/block/Action.java --- a/src/main/java/org/bukkit/event/block/Action.java
+++ b/src/main/java/org/bukkit/event/block/Action.java +++ b/src/main/java/org/bukkit/event/block/Action.java
@@ -29,5 +29,25 @@ public enum Action { @@ -29,5 +29,25 @@ public enum Action {
@ -17,20 +17,20 @@ index 25d26e3fe713311e66d7e634a6c32af61f4cef59..839dd6765c7b3338d5fc55d6f336cf7f
+ PHYSICAL; + PHYSICAL;
+ +
+ /** + /**
+ * Gets whether this action is a result of a left-hand click. + * Gets whether this action is a result of a left click.
+ * + *
+ * @return Whether it's a left-hand click + * @return Whether it's a left click
+ */ + */
+ public boolean isLeftHand() { + public boolean isLeftClick() {
+ return this == LEFT_CLICK_AIR || this == LEFT_CLICK_BLOCK; + return this == LEFT_CLICK_AIR || this == LEFT_CLICK_BLOCK;
+ } + }
+ +
+ /** + /**
+ * Gets whether this action is a result of a right-hand click. + * Gets whether this action is a result of a right click.
+ * + *
+ * @return Whether it's a right-hand click + * @return Whether it's a right click
+ */ + */
+ public boolean isRightHand() { + public boolean isRightClick() {
+ return this == RIGHT_CLICK_AIR || this == RIGHT_CLICK_BLOCK; + return this == RIGHT_CLICK_AIR || this == RIGHT_CLICK_BLOCK;
+ } + }
+ // Paper end + // Paper end