From eaccfc64b2a0cc7240e7b89faa3586f53e9fd8bb Mon Sep 17 00:00:00 2001 From: Zach Brown <1254957+zachbr@users.noreply.github.com> Date: Fri, 18 Mar 2016 21:41:50 -0500 Subject: [PATCH] Re-add comment to navigation patch --- Spigot-Server-Patches/Optimize-Navigation-Listener.patch | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Spigot-Server-Patches/Optimize-Navigation-Listener.patch b/Spigot-Server-Patches/Optimize-Navigation-Listener.patch index 5b2d38a9bf..b47e6a8169 100644 --- a/Spigot-Server-Patches/Optimize-Navigation-Listener.patch +++ b/Spigot-Server-Patches/Optimize-Navigation-Listener.patch @@ -66,6 +66,9 @@ index 0000000000000000000000000000000000000000..00000000000000000000000000000000 - for (int k = 0; k < j; ++k) { - NavigationAbstract navigationabstract = anavigationabstract1[k]; + */ ++ // DO NOT USE AN ITERATOR! This must be a for (;;) to avoid CME. ++ // This is perfectly safe, as additions are ok to be done in this iteration ++ // and Removals are queued instead of immediate. + for (int k = 0; k < this.navigators.size(); ++k) { + NavigationAbstract navigationabstract = this.navigators.get(k); + // Paper end