mirror of https://github.com/PaperMC/Paper.git
Mention master branch protection rules
This commit is contained in:
parent
65d1466c42
commit
eb701e5e40
|
@ -4,18 +4,18 @@ PaperMC is happy you're willing to contribute to our projects. We are usually
|
||||||
very lenient with all submitted PRs, but there are still some guidelines you
|
very lenient with all submitted PRs, but there are still some guidelines you
|
||||||
can follow to make the approval process go more smoothly.
|
can follow to make the approval process go more smoothly.
|
||||||
|
|
||||||
## Use a Personal Fork and not an Organization
|
## Branch Protection
|
||||||
|
|
||||||
Paper will routinely modify your PR, whether it's a quick rebase or to take care
|
Paper will routinely modify your PR, whether it's a quick rebase or to take care
|
||||||
of any minor nitpicks we might have. Often, it's better for us to solve these
|
of any minor nitpicks we might have. Often, it's better for us to solve these
|
||||||
problems for you than make you go back and forth trying to fix them yourself.
|
problems for you than make you go back and forth trying to fix them yourself.
|
||||||
|
|
||||||
Unfortunately, if you use an organization for your PR, it prevents Paper from
|
Unfortunately, if you use an organization or the master branch for your PR,
|
||||||
modifying it. This requires us to manually merge your PR, resulting in us
|
it prevents Paper from modifying it. This requires us to manually merge your
|
||||||
closing the PR instead of marking it as merged.
|
PR, resulting in us closing the PR instead of marking it as merged.
|
||||||
|
|
||||||
We much prefer to have PRs show as merged, so please do not use repositories
|
We much prefer to have PRs show as merged, so please do not use repositories
|
||||||
on organizations for PRs.
|
on organizations or the master branch for PRs.
|
||||||
|
|
||||||
See <https://github.com/isaacs/github/issues/1681> for more information on the
|
See <https://github.com/isaacs/github/issues/1681> for more information on the
|
||||||
issue.
|
issue.
|
||||||
|
|
Loading…
Reference in New Issue