Remove runner leak on async tasks. Fixes BUKKIT-3288

In some situations, an async task could be cancelled with no tasks
pending. This means the finally {} block from run() never gets executed
properly on the last async task to have run, as it expected to be
executed again.

This fix takes the only spot that the task period is set to cancelled
and will check to see if the task should be purged from the runners
list.

By: Wesley Wolfe <weswolf@aol.com>
This commit is contained in:
CraftBukkit/Spigot 2012-12-23 05:13:33 -06:00
parent ce8e581ffc
commit eeded7f6fd

View File

@ -100,6 +100,9 @@ class CraftAsyncTask extends CraftTask {
synchronized (workers) {
// Synchronizing here prevents race condition for a completing task
setPeriod(-2l);
if (workers.isEmpty()) {
runners.remove(getTaskId());
}
}
return true;
}