Commit Graph

11 Commits

Author SHA1 Message Date
Nassim Jahnke
c28d89d625
Update spark 2024-11-21 10:43:07 +01:00
Spottedleaf
8c5b837e05 Rework async chunk api implementation
Firstly, the old methods all routed to the CompletableFuture method.
However, the CF method could not guarantee that if the caller
was off-main that the future would be "completed" on-main. Since
the callback methods used the CF one, this meant that the callback
methods did not guarantee that the callbacks were to be called on
the main thread.

Now, all methods route to getChunkAtAsync(x, z, gen, urgent, cb)
so that the methods with the callback are guaranteed to invoke
the callback on the main thread. The CF behavior remains unchanged;
it may still appear to complete on main if invoked off-main.

Secondly, remove the scheduleOnMain invocation in the async
chunk completion. This unnecessarily delays the callback
by 1 tick.

Thirdly, add getChunksAtAsync(minX, minZ, maxX, maxZ, ...) which
will load chunks within an area. This method is provided as a helper
as keeping all chunks loaded within an area can be complicated to
implement for plugins (due to the lacking ticket API), and is
already implemented internally anyways.

Fourthly, remove the ticket addition that occured with getChunkAt
and getChunkAtAsync. The ticket addition may delay the unloading
of the chunk unnecessarily. It also fixes a very rare timing bug
where the future/callback would be completed after the chunk
unloads.
2024-11-18 23:00:59 -08:00
Owen
de6173b061
Item DataComponent API (#10845)
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
Co-authored-by: Lulu13022002 <41980282+Lulu13022002@users.noreply.github.com>
Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-11-18 15:09:44 -05:00
MiniDigger | Martin
d8b66dd93d fix: move to jline-terminal-ffm on java 22+ and fall back to jni on 21, fixes #10405
ffm requires 1) native access allowed (the jdk cracks down on undocumented native access in 22) and 2) reverting the default console back to java.base, so the internal jline doesnt take over
2024-11-18 17:01:08 +01:00
Yannick Lamprecht
e47f79acd9
Configure mockito agent (#11560) 2024-11-09 22:49:07 +01:00
Lulu13022002
d19be64b15
Fix NPE with spark when CraftServer is not init yet (#11558) 2024-11-01 21:37:45 +01:00
Noah van der Aa
7ee4835074
Correctly clear explosion density cache(#11541) 2024-10-31 22:30:18 +01:00
Jason Penilla
9e35192360
Execute spark tasks during tick sleep (#11525) 2024-10-27 22:00:06 +01:00
Nassim Jahnke
02bca1e655
Remove timings impl 2024-10-27 18:39:30 +01:00
Nassim Jahnke
348c855096
Readd last API patch (with TODO) 2024-10-27 10:03:59 +01:00
Nassim Jahnke
20507b45cf
Apply more patches 2024-10-26 18:16:39 +02:00