Commit Graph

24 Commits

Author SHA1 Message Date
Spottedleaf
7f61a2526e #640: Fix chunk load/unload callbacks for chunk load cancellations
When a chunk goes from a ticket level where it is loading a
full chunk to an inactive state (i.e ticket level 33 to
ticket level 45) the full status future will be completed
with a "Right" Either (indicating unloaded). However, this
will also schedule the unload callback immediately.

However, the callback is not immediately executed. This means
the next unload/load callback that needs to be scheduled will
fail. The fix applied is to not schedule a callback if the
chunk is not loaded - if the Either is "right."

Even better, due to how completablefuture works, exceptions
are not printed by default. So the exception thrown by the
callback executor was not printed and the failure
hidden from console. This explains why no-one has tracked this issue.
Now the exception is printed so future failures with the
callback system (if any) can be tracked easier.
2020-03-06 14:34:13 +11:00
md_5
e73aabd666 Update to Minecraft 1.14.4 2019-07-20 09:00:00 +10:00
Irmo van den Berge
989f9b3daa SPIGOT-4849: Fix server crash when accessing chunks during chunk load/unload/populate events 2019-07-16 10:54:41 +10:00
md_5
fe3930ce00 Update to Minecraft 1.14.3-pre4 2019-06-21 20:00:00 +10:00
blablubbabc
e8c0836216 SPIGOT-5046: World#getLoadedChunks returning inaccessible cached chunks. 2019-06-13 20:52:56 +10:00
md_5
cb3d14c5a7 Update to Minecraft 1.14.2 2019-05-28 06:30:00 +10:00
blablubbabc
8d0f37228d SPIGOT-4752: Fixed inconsistency between isChunkLoaded and chunk load/unload events 2019-05-25 10:47:30 +10:00
md_5
89c52b7b0e Update to Minecraft 1.14.1 2019-05-14 10:00:00 +10:00
md_5
a2d787f6eb Update to Minecraft 1.14-pre5 2019-04-23 12:00:00 +10:00
md_5
c64fe5080c Mappings Update 2018-12-13 11:00:00 +11:00
md_5
ce1af0c348 Update to Minecraft 1.13.1 2018-08-26 12:00:00 +10:00
md_5
421c1728c8 Update to Minecraft 1.13-pre7 2018-07-15 10:00:00 +10:00
md_5
5195487ec6 Update to Minecraft 1.12-pre2 2017-05-14 12:00:00 +10:00
md_5
c5e9a169fa Minecraft 1.9.4 2016-05-10 21:47:39 +10:00
Thinkofname
b5a4d07141 SPIGOT-2014: Respect the spectatorsGenerateChunks gamerule 2016-04-20 11:00:35 +01:00
Thinkofdeath
0cd6711085 Fix regenerating chunks not updating visually 2016-03-06 23:50:19 +00:00
md_5
aa008dff0f Update to Minecraft 1.9 2016-03-01 09:32:45 +11:00
Thinkofdeath
d8a9c7be42 Update to Minecraft 1.8.3 2015-03-04 09:48:58 +00:00
Thinkofdeath
e87122e110 Fix client chunk leak when preforming large block/chunk updates 2015-01-30 23:33:58 +00:00
Thinkofdeath
90ac03522a Revert "Remove patch headers"
This reverts commit d6e3dff7d8.
2014-11-28 23:02:15 +00:00
GunfighterJ
d6e3dff7d8 Remove patch headers 2014-11-28 16:54:14 -06:00
Thinkofdeath
2abdb9a061 Use the right name for the AsyncPlayerPreLoginEvent 2014-11-28 17:43:48 +00:00
Thinkofdeath
669c44cb3c Fix eating food whilst not facing a block 2014-11-28 11:23:19 +00:00
Thinkofdeath
24557bc2b3 Update to Minecraft 1.8
For more information please see http://www.spigotmc.org/
2014-11-28 17:16:30 +11:00