From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: virustotalop <virustotalop@gmail.com> Date: Thu, 16 Apr 2020 20:51:32 -0700 Subject: [PATCH] Optimize brigadier child sorting performance diff --git a/src/main/java/com/mojang/brigadier/tree/CommandNode.java b/src/main/java/com/mojang/brigadier/tree/CommandNode.java index 0000000000000000000000000000000000000000..0000000000000000000000000000000000000000 100644 --- a/src/main/java/com/mojang/brigadier/tree/CommandNode.java +++ b/src/main/java/com/mojang/brigadier/tree/CommandNode.java @@ -0,0 +0,0 @@ import java.util.function.Predicate; import net.minecraft.commands.CommandSourceStack; public abstract class CommandNode<S> implements Comparable<CommandNode<S>> { - private final Map<String, CommandNode<S>> children = new LinkedHashMap<>(); + private Map<String, CommandNode<S>> children = com.google.common.collect.Maps.newTreeMap(); // Paper - Switch to tree map for automatic sorting private final Map<String, LiteralCommandNode<S>> literals = new LinkedHashMap<>(); private final Map<String, ArgumentCommandNode<S, ?>> arguments = new LinkedHashMap<>(); public Predicate<S> requirement; @@ -0,0 +0,0 @@ public abstract class CommandNode<S> implements Comparable<CommandNode<S>> { this.arguments.put(node.getName(), (ArgumentCommandNode<S, ?>) node); } } + + // Paper - Remove manual sorting, it is no longer needed } public void findAmbiguities(final AmbiguityConsumer<S> consumer) {