From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: braindead Date: Sat, 5 Nov 2022 17:47:26 -0400 Subject: [PATCH] fix MC-252817 (green map markers do not disappear). this bug is caused by the fact that the itemframe's item is set to empty before the green marker is requested to be removed. this is fixed by getting the mapid from this method's parameter, rather than the air block now stored by the item frame. diff --git a/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java b/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java index db60d29b051bad8d115b333e6c72287860a73123..428523feaa4f30260e32ba03937e88200246c693 100644 --- a/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java +++ b/src/main/java/net/minecraft/world/entity/decoration/ItemFrame.java @@ -284,7 +284,9 @@ public class ItemFrame extends HangingEntity { } private void removeFramedMap(ItemStack itemstack) { - this.getFramedMapId().ifPresent((i) -> { + // Paper start - fix MC-252817 (green map markers do not disappear) + this.getFramedMapIdFromItem(itemstack).ifPresent((i) -> { + // Paper end MapItemSavedData worldmap = MapItem.getSavedData(i, this.level); if (worldmap != null) { @@ -302,7 +304,12 @@ public class ItemFrame extends HangingEntity { public OptionalInt getFramedMapId() { ItemStack itemstack = this.getItem(); + // Paper start - fix MC-252817 (green map markers do not disappear) + return this.getFramedMapIdFromItem(itemstack); + } + public OptionalInt getFramedMapIdFromItem(ItemStack itemstack) { + // Paper end if (itemstack.is(Items.FILLED_MAP)) { Integer integer = MapItem.getMapId(itemstack);