From 12e27b2338d7d8288e2827868316aacaf05dc9ac Mon Sep 17 00:00:00 2001 From: Aikar Date: Sun, 26 Aug 2018 20:49:50 -0400 Subject: [PATCH] Optimize RegistryMaterials Use larger initial sizes to increase bucket capacity on the BiMap BiMap.get was seen to be using a good bit of CPU time. diff --git a/src/main/java/net/minecraft/server/RegistryMaterials.java b/src/main/java/net/minecraft/server/RegistryMaterials.java index f291e05b26..fed38e6ef0 100644 --- a/src/main/java/net/minecraft/server/RegistryMaterials.java +++ b/src/main/java/net/minecraft/server/RegistryMaterials.java @@ -16,9 +16,9 @@ import org.apache.logging.log4j.Logger; public class RegistryMaterials extends IRegistryWritable { protected static final Logger LOGGER = LogManager.getLogger(); - protected final RegistryID b = new RegistryID<>(256); - protected final BiMap c = HashBiMap.create(); - protected Object[] d; + protected final RegistryID b = new RegistryID<>(2048); // Paper - use bigger expected size to reduce collisions + protected final BiMap c = HashBiMap.create(2048); // Paper - use bigger expected size to reduce collisions + protected T[] d; // Paper - Decompile fix private int R; public RegistryMaterials() {} @@ -98,7 +98,7 @@ public class RegistryMaterials extends IRegistryWritable { return null; } - this.d = collection.toArray(new Object[collection.size()]); + this.d = (T[]) collection.toArray(new Object[collection.size()]); // Paper - Decompile fix } return this.d[random.nextInt(this.d.length)]; -- 2.21.0