From c17359fff9d3b571e6f6eb5f2f44e8603889e269 Mon Sep 17 00:00:00 2001 From: Shane Freeder Date: Mon, 5 Nov 2018 04:23:51 +0000 Subject: [PATCH] Restore custom InventoryHolder support Upstream removed the ability to consistently use a custom InventoryHolder, However, the implementation does not use an InventoryHolder in any form outside of custom inventories. We can take that knowledge and apply some expected behavior, if we're given an inventory holder, we should use it and return a custom inventory with the holder, otherwise, create an inventory backed by the intended inventory, as per upstream behavior. This provides a "best of both worlds" scenario: plugins with InventoryHolder's will always work as intended in the past, those without will create implementation based inventories. diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/util/CraftInventoryCreator.java b/src/main/java/org/bukkit/craftbukkit/inventory/util/CraftInventoryCreator.java index 9957ed040..ae280dd40 100644 --- a/src/main/java/org/bukkit/craftbukkit/inventory/util/CraftInventoryCreator.java +++ b/src/main/java/org/bukkit/craftbukkit/inventory/util/CraftInventoryCreator.java @@ -39,10 +39,20 @@ public final class CraftInventoryCreator { } public Inventory createInventory(InventoryHolder holder, InventoryType type) { + // Paper start + if (holder != null) { + return DEFAULT_CONVERTER.createInventory(holder, type); + } + //noinspection ConstantConditions // Paper end return converterMap.get(type).createInventory(holder, type); } public Inventory createInventory(InventoryHolder holder, InventoryType type, String title) { + // Paper start + if (holder != null) { + return DEFAULT_CONVERTER.createInventory(holder, type, title); + } + //noinspection ConstantConditions // Paper end return converterMap.get(type).createInventory(holder, type, title); } -- 2.24.1