From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Phoenix616 Date: Sun, 7 Jun 2020 21:43:42 +0100 Subject: [PATCH] Maps shouldn't load chunks Previously maps would load all chunks in a certain radius depending on their scale when trying to update their content. This would result in main thread chunk loads when they weren't really necessary, especially on low view distances or "slow" async chunk loads after teleports or other prioritisation. This changes it to only try to render already loaded chunks based on the assumption that the chunks around the player will get loaded eventually anyways and that maps will get checked for update every five ticks that movement occur in anyways. diff --git a/src/main/java/net/minecraft/world/item/ItemWorldMap.java b/src/main/java/net/minecraft/world/item/ItemWorldMap.java index b18149cf048e78fefc019b50ed8f20ff8b609f5c..a1945e9ac1dd8961c5758a22bef3908d3adf0704 100644 --- a/src/main/java/net/minecraft/world/item/ItemWorldMap.java +++ b/src/main/java/net/minecraft/world/item/ItemWorldMap.java @@ -120,9 +120,9 @@ public class ItemWorldMap extends ItemWorldMapBase { int k2 = (j / i + k1 - 64) * i; int l2 = (k / i + l1 - 64) * i; Multiset multiset = LinkedHashMultiset.create(); - Chunk chunk = world.getChunkAtWorldCoords(new BlockPosition(k2, 0, l2)); + Chunk chunk = world.getChunkIfLoaded(new BlockPosition(k2, 0, l2)); // Paper - Maps shouldn't load chunks - if (!chunk.isEmpty()) { + if (chunk != null && !chunk.isEmpty()) { // Paper - Maps shouldn't load chunks ChunkCoordIntPair chunkcoordintpair = chunk.getPos(); int i3 = k2 & 15; int j3 = l2 & 15;