From a93dbd34267517151430f2dbab273a5ae3b49802 Mon Sep 17 00:00:00 2001 From: md_5 Date: Fri, 8 Aug 2014 19:57:03 +1000 Subject: [PATCH] Plug WorldMap Memory Leak diff --git a/src/main/java/net/minecraft/server/PersistentCollection.java b/src/main/java/net/minecraft/server/PersistentCollection.java index c29e3f7..6f013eb 100644 --- a/src/main/java/net/minecraft/server/PersistentCollection.java +++ b/src/main/java/net/minecraft/server/PersistentCollection.java @@ -18,7 +18,7 @@ public class PersistentCollection { private IDataManager b; protected Map a = Maps.newHashMap(); - private List c = Lists.newArrayList(); + public List c = Lists.newArrayList(); // Spigot private Map d = Maps.newHashMap(); public PersistentCollection(IDataManager idatamanager) { diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java index 3ffb6da..d09942c 100644 --- a/src/main/java/net/minecraft/server/World.java +++ b/src/main/java/net/minecraft/server/World.java @@ -1006,6 +1006,23 @@ public abstract class World implements IBlockAccess { entity.die(); if (entity instanceof EntityHuman) { this.players.remove(entity); + // Spigot start + for ( Object o : worldMaps.c ) + { + if ( o instanceof WorldMap ) + { + WorldMap map = (WorldMap) o; + map.j.remove( entity ); + for ( Iterator iter = (Iterator) map.h.iterator(); iter.hasNext(); ) + { + if ( iter.next().trackee == entity ) + { + iter.remove(); + } + } + } + } + // Spigot end this.everyoneSleeping(); this.c(entity); } diff --git a/src/main/java/net/minecraft/server/WorldMap.java b/src/main/java/net/minecraft/server/WorldMap.java index bf53fe5..d0d7c9d 100644 --- a/src/main/java/net/minecraft/server/WorldMap.java +++ b/src/main/java/net/minecraft/server/WorldMap.java @@ -23,7 +23,7 @@ public class WorldMap extends PersistentBase { public byte scale; public byte[] colors = new byte[16384]; public List h = Lists.newArrayList(); - private Map j = Maps.newHashMap(); + public Map j = Maps.newHashMap(); // Spigot public Map decorations = Maps.newLinkedHashMap(); // CraftBukkit start -- 2.5.0