From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jake Potrebic Date: Sat, 21 Aug 2021 17:25:38 -0700 Subject: [PATCH] API for updating recipes on clients diff --git a/src/main/java/net/minecraft/server/players/PlayerList.java b/src/main/java/net/minecraft/server/players/PlayerList.java index 4b3a121e8443aa0e0e7cd26806e7d5b00ddf59af..468231acdf3bb3d8e92be5636b5a32a103709cd1 100644 --- a/src/main/java/net/minecraft/server/players/PlayerList.java +++ b/src/main/java/net/minecraft/server/players/PlayerList.java @@ -1518,6 +1518,13 @@ public abstract class PlayerList { } public void reloadResources() { + // Paper start - split this method up into separate methods + this.reloadAdvancementData(); + this.reloadTagData(); + this.reloadRecipeData(); + } + public void reloadAdvancementData() { + // Paper end // CraftBukkit start /*Iterator iterator = this.advancements.values().iterator(); @@ -1533,7 +1540,15 @@ public abstract class PlayerList { } // CraftBukkit end + // Paper start + } + public void reloadTagData() { + // Paper end this.broadcastAll(new ClientboundUpdateTagsPacket(TagNetworkSerialization.serializeTagsToNetwork(this.registries))); + // Paper start + } + public void reloadRecipeData() { + // Paper end ClientboundUpdateRecipesPacket packetplayoutrecipeupdate = new ClientboundUpdateRecipesPacket(this.server.getRecipeManager().getRecipes()); Iterator iterator1 = this.players.iterator(); diff --git a/src/main/java/org/bukkit/craftbukkit/CraftServer.java b/src/main/java/org/bukkit/craftbukkit/CraftServer.java index 4794cea2353c47bd57c86e37beb1164629791211..a97136b944991bc93d7e33a375cfae717ea86220 100644 --- a/src/main/java/org/bukkit/craftbukkit/CraftServer.java +++ b/src/main/java/org/bukkit/craftbukkit/CraftServer.java @@ -1131,6 +1131,18 @@ public final class CraftServer implements Server { ReloadCommand.reload(console); } + // Paper start + @Override + public void updateResources() { + this.playerList.reloadResources(); + } + + @Override + public void updateRecipes() { + this.playerList.reloadRecipeData(); + } + // Paper end + private void loadIcon() { this.icon = new CraftIconCache(null); try { @@ -1474,6 +1486,13 @@ public final class CraftServer implements Server { @Override public boolean addRecipe(Recipe recipe) { + // Paper start + return this.addRecipe(recipe, false); + } + + @Override + public boolean addRecipe(Recipe recipe, boolean resendRecipes) { + // Paper end CraftRecipe toAdd; if (recipe instanceof CraftRecipe) { toAdd = (CraftRecipe) recipe; @@ -1503,6 +1522,11 @@ public final class CraftServer implements Server { } } toAdd.addToCraftingManager(); + // Paper start + if (resendRecipes) { + this.playerList.reloadRecipeData(); + } + // Paper end return true; } @@ -1622,10 +1646,23 @@ public final class CraftServer implements Server { @Override public boolean removeRecipe(NamespacedKey recipeKey) { + // Paper start + return this.removeRecipe(recipeKey, false); + } + + @Override + public boolean removeRecipe(NamespacedKey recipeKey, boolean resendRecipes) { + // Paper end Preconditions.checkArgument(recipeKey != null, "recipeKey == null"); ResourceLocation mcKey = CraftNamespacedKey.toMinecraft(recipeKey); - return this.getServer().getRecipeManager().removeRecipe(mcKey); + // Paper start - resend recipes on successful removal + boolean removed = this.getServer().getRecipeManager().removeRecipe(mcKey); + if (removed && resendRecipes) { + this.playerList.reloadRecipeData(); + } + return removed; + // Paper end } @Override