mirror of https://github.com/PaperMC/Paper.git
174 lines
7.5 KiB
Diff
174 lines
7.5 KiB
Diff
From 9e5facb25e4f5cd1aefa2709f65a6b3b54f69f12 Mon Sep 17 00:00:00 2001
|
|
From: md_5 <git@md-5.net>
|
|
Date: Tue, 25 Mar 2014 16:10:01 +1100
|
|
Subject: [PATCH] Async Operation Catching
|
|
|
|
Catch and throw an exception when a potentially unsafe operation occurs on a thread other than the main server thread.
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/Block.java b/src/main/java/net/minecraft/server/Block.java
|
|
index 12e2b79..9a19752 100644
|
|
--- a/src/main/java/net/minecraft/server/Block.java
|
|
+++ b/src/main/java/net/minecraft/server/Block.java
|
|
@@ -268,9 +268,13 @@ public class Block {
|
|
return 10;
|
|
}
|
|
|
|
- public void onPlace(World world, BlockPosition blockposition, IBlockData iblockdata) {}
|
|
+ public void onPlace(World world, BlockPosition blockposition, IBlockData iblockdata) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "block onPlace"); // Spigot
|
|
+ }
|
|
|
|
- public void remove(World world, BlockPosition blockposition, IBlockData iblockdata) {}
|
|
+ public void remove(World world, BlockPosition blockposition, IBlockData iblockdata) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "block remove"); // Spigot
|
|
+ }
|
|
|
|
public int a(Random random) {
|
|
return 1;
|
|
diff --git a/src/main/java/net/minecraft/server/EntityTracker.java b/src/main/java/net/minecraft/server/EntityTracker.java
|
|
index c9058db..350f2f7 100644
|
|
--- a/src/main/java/net/minecraft/server/EntityTracker.java
|
|
+++ b/src/main/java/net/minecraft/server/EntityTracker.java
|
|
@@ -94,6 +94,7 @@ public class EntityTracker {
|
|
}
|
|
|
|
public void addEntity(Entity entity, int i, int j, boolean flag) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "entity track"); // Spigot
|
|
if (i > this.e) {
|
|
i = this.e;
|
|
}
|
|
@@ -129,6 +130,7 @@ public class EntityTracker {
|
|
}
|
|
|
|
public void untrackEntity(Entity entity) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "entity untrack"); // Spigot
|
|
if (entity instanceof EntityPlayer) {
|
|
EntityPlayer entityplayer = (EntityPlayer) entity;
|
|
Iterator iterator = this.c.iterator();
|
|
diff --git a/src/main/java/net/minecraft/server/EntityTrackerEntry.java b/src/main/java/net/minecraft/server/EntityTrackerEntry.java
|
|
index 7c58740..f5d518f 100644
|
|
--- a/src/main/java/net/minecraft/server/EntityTrackerEntry.java
|
|
+++ b/src/main/java/net/minecraft/server/EntityTrackerEntry.java
|
|
@@ -308,6 +308,7 @@ public class EntityTrackerEntry {
|
|
}
|
|
|
|
public void updatePlayer(EntityPlayer entityplayer) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "player tracker update"); // Spigot
|
|
if (entityplayer != this.tracker) {
|
|
if (this.c(entityplayer)) {
|
|
if (!this.trackedPlayers.contains(entityplayer) && (this.e(entityplayer) || this.tracker.attachedToPlayer)) {
|
|
@@ -536,6 +537,7 @@ public class EntityTrackerEntry {
|
|
}
|
|
|
|
public void clear(EntityPlayer entityplayer) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "player tracker clear"); // Spigot
|
|
if (this.trackedPlayers.contains(entityplayer)) {
|
|
this.trackedPlayers.remove(entityplayer);
|
|
entityplayer.d(this.tracker);
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
|
index 4cd59aa..a16be9b 100644
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
|
@@ -878,6 +878,7 @@ public abstract class World implements IBlockAccess {
|
|
}
|
|
|
|
public boolean addEntity(Entity entity, SpawnReason spawnReason) { // Changed signature, added SpawnReason
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "entity add"); // Spigot
|
|
if (entity == null) return false;
|
|
// CraftBukkit end
|
|
int i = MathHelper.floor(entity.locX / 16.0D);
|
|
@@ -985,6 +986,7 @@ public abstract class World implements IBlockAccess {
|
|
}
|
|
|
|
public void removeEntity(Entity entity) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "entity remove"); // Spigot
|
|
entity.die();
|
|
if (entity instanceof EntityHuman) {
|
|
this.players.remove(entity);
|
|
@@ -2410,6 +2412,7 @@ public abstract class World implements IBlockAccess {
|
|
}
|
|
|
|
public void b(Collection collection) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "entity world add"); // Spigot
|
|
// CraftBukkit start
|
|
// this.entityList.addAll(collection);
|
|
Iterator iterator = collection.iterator();
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
|
index 17d24ce..a45f2a3 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/CraftWorld.java
|
|
@@ -162,6 +162,7 @@ public class CraftWorld implements World {
|
|
}
|
|
|
|
public boolean unloadChunkRequest(int x, int z, boolean safe) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "chunk unload"); // Spigot
|
|
if (safe && isChunkInUse(x, z)) {
|
|
return false;
|
|
}
|
|
@@ -172,6 +173,7 @@ public class CraftWorld implements World {
|
|
}
|
|
|
|
public boolean unloadChunk(int x, int z, boolean save, boolean safe) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "chunk unload"); // Spigot
|
|
if (safe && isChunkInUse(x, z)) {
|
|
return false;
|
|
}
|
|
@@ -239,6 +241,7 @@ public class CraftWorld implements World {
|
|
}
|
|
|
|
public boolean loadChunk(int x, int z, boolean generate) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "chunk load"); // Spigot
|
|
chunkLoadCount++;
|
|
if (generate) {
|
|
// Use the default variant of loadChunk when generate == true.
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
|
index fb07b7d..01b1822 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/entity/CraftPlayer.java
|
|
@@ -214,6 +214,7 @@ public class CraftPlayer extends CraftHumanEntity implements Player {
|
|
|
|
@Override
|
|
public void kickPlayer(String message) {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "player kick"); // Spigot
|
|
if (getHandle().playerConnection == null) return;
|
|
|
|
getHandle().playerConnection.disconnect(message == null ? "" : message);
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java b/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java
|
|
index 87259f1..295aed2 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftScoreboardManager.java
|
|
@@ -42,6 +42,7 @@ public final class CraftScoreboardManager implements ScoreboardManager {
|
|
}
|
|
|
|
public CraftScoreboard getNewScoreboard() {
|
|
+ org.spigotmc.AsyncCatcher.catchOp( "scoreboard creation"); // Spigot
|
|
CraftScoreboard scoreboard = new CraftScoreboard(new ScoreboardServer(server));
|
|
scoreboards.add(scoreboard);
|
|
return scoreboard;
|
|
diff --git a/src/main/java/org/spigotmc/AsyncCatcher.java b/src/main/java/org/spigotmc/AsyncCatcher.java
|
|
new file mode 100644
|
|
index 0000000..4b3aa85
|
|
--- /dev/null
|
|
+++ b/src/main/java/org/spigotmc/AsyncCatcher.java
|
|
@@ -0,0 +1,17 @@
|
|
+package org.spigotmc;
|
|
+
|
|
+import net.minecraft.server.MinecraftServer;
|
|
+
|
|
+public class AsyncCatcher
|
|
+{
|
|
+
|
|
+ public static boolean enabled = true;
|
|
+
|
|
+ public static void catchOp(String reason)
|
|
+ {
|
|
+ if ( enabled && Thread.currentThread() != MinecraftServer.getServer().primaryThread )
|
|
+ {
|
|
+ throw new IllegalStateException( "Asynchronous " + reason + "!" );
|
|
+ }
|
|
+ }
|
|
+}
|
|
--
|
|
2.1.0
|
|
|