mirror of
https://github.com/PaperMC/Paper.git
synced 2024-09-06 03:48:05 +02:00
There is no reason for the light queue to even be an option. This enables the light queue for everyone. This also improves the "can we still tick" time logic to always check before running a light operation. previously, we always executed at least 10 on the first world (but not other worlds...), but we are seeing light take up some heavy time, so improving that for now. I've now also improved recheck gaps logic to happen at the end of all single block updates This also prevents multiple gap checks, as previously if a tick skipped the gaps check, the next tick would end up re-adding the entry again, resulting in multiple gap checks. This now just sets a marker "We need to recheck gaps" and will only occur once. This also should reduce chunk loads, as previously, we checked if the neighbor chunks were loaded for the gap check, however those neighbor chunks might of unloaded before the light queue operation actually ran. Now, the neighbor chunk is done when the gap check is being done, so it should avoid loading chunks. Fixes #1466 Fixes #1431
156 lines
6.9 KiB
Diff
156 lines
6.9 KiB
Diff
From 9b89ac214dad604784dbbe857ea7a1941f2a2fdc Mon Sep 17 00:00:00 2001
|
|
From: Aikar <aikar@aikar.co>
|
|
Date: Fri, 18 Mar 2016 20:16:03 -0400
|
|
Subject: [PATCH] Add World Util Methods
|
|
|
|
Methods that can be used for other patches to help improve logic.
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/Chunk.java b/src/main/java/net/minecraft/server/Chunk.java
|
|
index ab579b9052..b006282f38 100644
|
|
--- a/src/main/java/net/minecraft/server/Chunk.java
|
|
+++ b/src/main/java/net/minecraft/server/Chunk.java
|
|
@@ -633,6 +633,7 @@ public class Chunk implements IChunkAccess {
|
|
}
|
|
}
|
|
|
|
+ public final int getLightSubtracted(BlockPosition blockposition, int i) { return this.a(blockposition, i); } // Paper - OBFHELPER
|
|
public int a(BlockPosition blockposition, int i) {
|
|
return this.a(blockposition, i, this.world.o().g());
|
|
}
|
|
diff --git a/src/main/java/net/minecraft/server/IWorldReader.java b/src/main/java/net/minecraft/server/IWorldReader.java
|
|
index ac85986a1a..06c5a54254 100644
|
|
--- a/src/main/java/net/minecraft/server/IWorldReader.java
|
|
+++ b/src/main/java/net/minecraft/server/IWorldReader.java
|
|
@@ -35,6 +35,22 @@ public interface IWorldReader extends IBlockAccess {
|
|
}
|
|
|
|
int getLightLevel(BlockPosition var1, int var2);
|
|
+ // Paper start
|
|
+ default @Nullable
|
|
+ IBlockData getTypeIfLoaded(BlockPosition var1) {
|
|
+ return isLoaded(var1) ? getType(var1) : null;
|
|
+ }
|
|
+
|
|
+ default @Nullable
|
|
+ Block getBlockIfLoaded(BlockPosition var1) {
|
|
+ return isLoaded(var1) ? getType(var1).getBlock() : null;
|
|
+ }
|
|
+
|
|
+ default @Nullable
|
|
+ Material getMaterialIfLoaded(BlockPosition var1) {
|
|
+ return isLoaded(var1) ? getType(var1).getMaterial() : null;
|
|
+ }
|
|
+ // Paper end
|
|
|
|
boolean isChunkLoaded(int var1, int var2, boolean var3);
|
|
|
|
@@ -100,7 +116,7 @@ public interface IWorldReader extends IBlockAccess {
|
|
WorldBorder worldborder = this.getWorldBorder();
|
|
boolean flag1 = worldborder.b() < (double)i && (double)j < worldborder.d() && worldborder.c() < (double)i1 && (double)j1 < worldborder.e();
|
|
VoxelShapeBitSet voxelshapebitset = new VoxelShapeBitSet(j - i, l - k, j1 - i1);
|
|
- Predicate predicate = (voxelshape3) -> {
|
|
+ Predicate<VoxelShape> predicate = (voxelshape3) -> { // Paper - decompile fix
|
|
return !voxelshape3.b() && VoxelShapes.c(voxelshape, voxelshape3, OperatorBoolean.AND);
|
|
};
|
|
Stream stream = StreamSupport.stream(BlockPosition.MutableBlockPosition.b(i, k, i1, j - 1, l - 1, j1 - 1).spliterator(), false).map((blockposition$mutableblockposition) -> {
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
|
index 19eb905979..275978de83 100644
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
|
@@ -84,7 +84,7 @@ public abstract class World implements IEntityAccess, GeneratorAccess, IIBlockAc
|
|
public final List<Entity> k = Lists.newArrayList();
|
|
protected final IntHashMap<Entity> entitiesById = new IntHashMap();
|
|
private final long F = 16777215L;
|
|
- private int G;
|
|
+ private int G; public int getSkylightSubtracted() { return this.G; } public void setSkylightSubtracted(int value) { this.G = value;} // Paper - OBFHELPER
|
|
protected int m = (new Random()).nextInt();
|
|
protected final int n = 1013904223;
|
|
protected float o;
|
|
@@ -274,6 +274,83 @@ public abstract class World implements IEntityAccess, GeneratorAccess, IIBlockAc
|
|
return this.getType(blockposition).isAir();
|
|
}
|
|
|
|
+ // Paper start
|
|
+ public boolean isLoadedAndInBounds(BlockPosition blockposition) {
|
|
+ return getWorldBorder().isInBounds(blockposition) && getChunkIfLoaded(blockposition.getX() >> 4, blockposition.getZ() >> 4) != null;
|
|
+ }
|
|
+ public Chunk getChunkIfLoaded(BlockPosition blockposition) {
|
|
+ return getChunkIfLoaded(blockposition.getX() >> 4, blockposition.getZ() >> 4);
|
|
+ }
|
|
+ // test if meets light level, return faster
|
|
+ // logic copied from below
|
|
+ public boolean isLightLevel(BlockPosition blockposition, int level) {
|
|
+ if (isValidLocation(blockposition)) {
|
|
+ if (this.getType(blockposition).c(this, blockposition)) {
|
|
+ int sky = getSkylightSubtracted();
|
|
+ if (this.getLightLevel(blockposition.up(), sky) >= level) {
|
|
+ return true;
|
|
+ }
|
|
+ if (this.getLightLevel(blockposition.east(), sky) >= level) {
|
|
+ return true;
|
|
+ }
|
|
+ if (this.getLightLevel(blockposition.west(), sky) >= level) {
|
|
+ return true;
|
|
+ }
|
|
+ if (this.getLightLevel(blockposition.south(), sky) >= level) {
|
|
+ return true;
|
|
+ }
|
|
+ if (this.getLightLevel(blockposition.north(), sky) >= level) {
|
|
+ return true;
|
|
+ }
|
|
+ return false;
|
|
+ } else {
|
|
+ if (blockposition.getY() >= 256) {
|
|
+ blockposition = new BlockPosition(blockposition.getX(), 255, blockposition.getZ());
|
|
+ }
|
|
+
|
|
+ Chunk chunk = this.getChunkAtWorldCoords(blockposition);
|
|
+ return chunk.getLightSubtracted(blockposition, this.getSkylightSubtracted()) >= level;
|
|
+ }
|
|
+ } else {
|
|
+ return true;
|
|
+ }
|
|
+ }
|
|
+ // reduces need to do isLoaded before getType
|
|
+ public IBlockData getTypeIfLoadedAndInBounds(BlockPosition blockposition) {
|
|
+ return getWorldBorder().isInBounds(blockposition) ? getTypeIfLoaded(blockposition) : null;
|
|
+ }
|
|
+ public IBlockData getTypeIfLoaded(BlockPosition blockposition) {
|
|
+ // CraftBukkit start - tree generation
|
|
+ if (captureTreeGeneration) {
|
|
+ for (CraftBlockState previous : capturedBlockStates) {
|
|
+ if (previous.getX() == blockposition.getX() && previous.getY() == blockposition.getY() && previous.getZ() == blockposition.getZ()) {
|
|
+ return previous.getHandle();
|
|
+ }
|
|
+ }
|
|
+ }
|
|
+ // CraftBukkit end
|
|
+ Chunk chunk = this.getChunkIfLoaded(blockposition);
|
|
+ if (chunk != null) {
|
|
+ return isValidLocation(blockposition) ? chunk.getBlockData(blockposition) : Blocks.AIR.getBlockData();
|
|
+ }
|
|
+ return null;
|
|
+ }
|
|
+ public Block getBlockIfLoaded(BlockPosition blockposition) {
|
|
+ IBlockData type = getTypeIfLoaded(blockposition);
|
|
+ if (type == null) {
|
|
+ return null;
|
|
+ }
|
|
+ return type.getBlock();
|
|
+ }
|
|
+ public Material getMaterialIfLoaded(BlockPosition blockposition) {
|
|
+ IBlockData type = getTypeIfLoaded(blockposition);
|
|
+ if (type == null) {
|
|
+ return null;
|
|
+ }
|
|
+ return type.getBlock().material;
|
|
+ }
|
|
+ // Paper end
|
|
+
|
|
public Chunk getChunkAtWorldCoords(BlockPosition blockposition) {
|
|
return this.getChunkAt(blockposition.getX() >> 4, blockposition.getZ() >> 4);
|
|
}
|
|
--
|
|
2.19.0
|
|
|