High performance Spigot fork that aims to fix gameplay and mechanics inconsistencies

bukkitcraftbukkithacktoberfestjavaminecraftminecraft-apiminecraft-performanceminecraft-serverpaperpaper-apipapermcspigot-forktacos

Jake Potrebic 29d059d659 Fix sticky pistons and BlockPistonRetractEvent ... There is an explicit check in the handling code for empty pistons that prevents sticky pistons from firing the event. However when we look back at the history we see that this check was originally added so that ONLY sticky pistons would fire the retract event. I'm not sure why. 1092acbddf Over the course of several updates, the meaning of that field appears to have changed from "is NOT sticky" to "is sticky". So now its having the opposite effect. Only normal pistons fire the retraction event. And like all things in CB, it's just been carried around since. If we are to believe the history, the correct fix for this issue is to flip it so it only fires for sticky pistons, but that puts us in a bind. It's already firing for non-sticky pistons, changing it now would likely result in breakage. Furthermore, there is little documentation as to WHY that was ever intended to be the case. Instead we opt to remove the check entirely so that the event fires for all piston types. Co-authored-by: Zach Brown <1254957+zachbr@users.noreply.github.com> Co-authored-by: Madeline Miller <mnmiller1@me.com>		2021-12-22 09:51:48 -08:00
paper-server	Fix sticky pistons and BlockPistonRetractEvent	2021-12-22 09:51:48 -08:00