Mike Primm 32924f9757 [Bleeding] Fix corruption due to thread safety issues. Fixes BUKKIT-3333 ... The 'tag' NBTTagCompound field of the ItemStack assumes that it is OK to save a reference to an NBT supplied via load() and assumes it is OK to supply a reference to the internal field during a save(). Neither is true, as Chunk NBT structures are required to be read-only once created (due to being written asynchronously off the server thread AND due to the potential to be passed to a new Chunk if the same chunk is reloaded before the writing of the NBT is completed by the File I/O thread). Keeping a live reference to the NBT copy passed in, or to the NBT value passed back during saving, creates serious thread safety issues which can result in corrupted data being written to the world data files. The specific issue here was uncovered by the recent change to use setName("") on the ItemStack.tag object. When a chunk is being loaded again before its save is completed, this results in name of the field in the NBT being set to "". This causes it to be saved as "" instead of "tag" resulting in it not being properly reloaded in the future which results in the itemstack losing all of its metadata.		2012-12-30 23:31:22 -06:00
..
java	[Bleeding] Fix corruption due to thread safety issues. Fixes BUKKIT-3333	2012-12-30 23:31:22 -06:00
resources/configurations	[Bleeding] Implement periodic chunk garbage collector	2012-12-29 16:50:05 -06:00