Paper/patches
Bjarne Koll 42fecd0a5f
Correctly shrink items during EntityResurrectEvent (#8780)
The EntityResurrectEvent logic is supposed to locate a totem of undying
in any of the interaction slots of the player inventory and then, if the
called EntityResurrectEvent is not cancelled, shrink that item by 1,
usually reducing it to zero.

For this, the logic iterates over the items in the interaction slots and
breaks out the loop if a totem of undying was found.
However, even if no totem of undying was found, the iteration item stack
variable remains as a refernce to the last interaction slot probed.

Plugins uncancelling a EntityResurrectEvent, which is published
pre-cancelled to listeners if no totem of undying could be found,
would hence cause the server logic to shrink completely unrelated items
found in, at the writing of this patch, the players off hand slot.

This patch corrects this behaviour by only shrinking the item if a totem
of undying was found and the event was called uncancelled.
2023-01-19 23:09:08 +01:00
..
api Don't clone location in PreCreatureSpawnEvent (#8790) 2023-01-16 16:03:58 +01:00
removed [ci skip] Remove non-functioning patch 2022-12-10 21:40:18 -07:00
server Correctly shrink items during EntityResurrectEvent (#8780) 2023-01-19 23:09:08 +01:00