mirror of
https://github.com/PaperMC/Paper.git
synced 2024-11-22 18:45:54 +01:00
89d51d5f29
Because this exploit has been widely known for years and has not been fixed by Mojang, we decided that it was worth allowing people to toggle it on/off due to how easy it is to make it configurable. It should be noted that this decision does not promise all future exploits will be configurable.
55 lines
2.9 KiB
Diff
55 lines
2.9 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: The456gamer <the456gamer@the456gamer.dev>
|
|
Date: Mon, 28 Aug 2023 01:32:39 +0100
|
|
Subject: [PATCH] Fix spigot's Forced-Stats
|
|
|
|
moves the loading after vanilla loading, so it overrides the values.
|
|
disables saving any forced stats, so it stays at the same value (without enabling disableStatSaving)
|
|
fixes stat initialization to not cause a NullPointerException
|
|
|
|
diff --git a/src/main/java/net/minecraft/stats/ServerStatsCounter.java b/src/main/java/net/minecraft/stats/ServerStatsCounter.java
|
|
index 9501e5f25f5c4d3069e554d4dc82b0e094156682..f890738d3bb9fb5e70a9d323c6cec97f9948f9cf 100644
|
|
--- a/src/main/java/net/minecraft/stats/ServerStatsCounter.java
|
|
+++ b/src/main/java/net/minecraft/stats/ServerStatsCounter.java
|
|
@@ -48,13 +48,6 @@ public class ServerStatsCounter extends StatsCounter {
|
|
public ServerStatsCounter(MinecraftServer server, File file) {
|
|
this.server = server;
|
|
this.file = file;
|
|
- // Spigot start
|
|
- for ( Map.Entry<ResourceLocation, Integer> entry : org.spigotmc.SpigotConfig.forcedStats.entrySet() )
|
|
- {
|
|
- Stat<ResourceLocation> wrapper = Stats.CUSTOM.get( entry.getKey() );
|
|
- this.stats.put( wrapper, entry.getValue().intValue() );
|
|
- }
|
|
- // Spigot end
|
|
if (file.isFile()) {
|
|
try {
|
|
this.parseLocal(server.getFixerUpper(), FileUtils.readFileToString(file));
|
|
@@ -65,6 +58,18 @@ public class ServerStatsCounter extends StatsCounter {
|
|
}
|
|
}
|
|
|
|
+ // Paper start - Moved after stat fetching for player state file
|
|
+ // Moves the loading after vanilla loading, so it overrides the values.
|
|
+ // Disables saving any forced stats, so it stays at the same value (without enabling disableStatSaving)
|
|
+ // Fixes stat initialization to not cause a NullPointerException
|
|
+ // Spigot start
|
|
+ for ( Map.Entry<ResourceLocation, Integer> entry : org.spigotmc.SpigotConfig.forcedStats.entrySet() )
|
|
+ {
|
|
+ Stat<ResourceLocation> wrapper = Stats.CUSTOM.get(java.util.Objects.requireNonNull(BuiltInRegistries.CUSTOM_STAT.get(entry.getKey()))); // Paper - ensured by SpigotConfig#stats
|
|
+ this.stats.put( wrapper, entry.getValue().intValue() );
|
|
+ }
|
|
+ // Spigot end
|
|
+ // Paper end - Moved after stat fetching for player state file
|
|
}
|
|
|
|
public void save() {
|
|
@@ -80,6 +85,7 @@ public class ServerStatsCounter extends StatsCounter {
|
|
@Override
|
|
public void setValue(Player player, Stat<?> stat, int value) {
|
|
if ( org.spigotmc.SpigotConfig.disableStatSaving ) return; // Spigot
|
|
+ if (stat.getType() == Stats.CUSTOM && stat.getValue() instanceof final ResourceLocation resourceLocation && org.spigotmc.SpigotConfig.forcedStats.get(resourceLocation) != null) return; // Paper - disable saving forced stats
|
|
super.setValue(player, stat, value);
|
|
this.dirty.add(stat);
|
|
}
|