mirror of
https://github.com/PaperMC/Paper.git
synced 2024-10-04 01:17:56 +02:00
41647af74c
We cannot put blocking network I/O onto the worldgen threads, this will crash the server if it stalls
23 lines
1.3 KiB
Diff
23 lines
1.3 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: chickeneer <emcchickeneer@gmail.com>
|
|
Date: Fri, 19 Mar 2021 00:33:15 -0500
|
|
Subject: [PATCH] Fix PlayerItemConsumeEvent cancelling properly
|
|
|
|
When the active item is not cleared, the item is still readied
|
|
for use and will repeatedly trigger the PlayerItemConsumeEvent
|
|
till their item is switched.
|
|
This patch clears the active item when the event is cancelled
|
|
|
|
diff --git a/src/main/java/net/minecraft/world/entity/LivingEntity.java b/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
|
index 20816ccecd427ca747719dea5fd6c2d5544b71ff..85a0a295ce7739e340ada69e5a970b742dd95004 100644
|
|
--- a/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
|
+++ b/src/main/java/net/minecraft/world/entity/LivingEntity.java
|
|
@@ -3752,6 +3752,7 @@ public abstract class LivingEntity extends Entity {
|
|
level.getCraftServer().getPluginManager().callEvent(event);
|
|
|
|
if (event.isCancelled()) {
|
|
+ this.stopUsingItem(); // Paper - event is using an item, clear active item to reset its use
|
|
// Update client
|
|
((ServerPlayer) this).getBukkitEntity().updateInventory();
|
|
((ServerPlayer) this).getBukkitEntity().updateScaledHealth();
|